[Improvement-18056] Clean up unused methods and classes in the dolphinschudler-master module#18164
Open
njnu-seafish wants to merge 6 commits intoapache:devfrom
Open
[Improvement-18056] Clean up unused methods and classes in the dolphinschudler-master module#18164njnu-seafish wants to merge 6 commits intoapache:devfrom
njnu-seafish wants to merge 6 commits intoapache:devfrom
Conversation
njnu-seafish
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
SbloodyS
reviewed
Apr 13, 2026
Member
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
I'm not sure if these files no longer useful. cc @ruanwenjun
…er-syc # Conflicts: # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/listener/ITaskExecutionLifecycleListener.java # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowFinalizeLifecycleEventHandler.java # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/listener/WorkflowSuccessLifecycleListener.java # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/WorkflowInstanceUtils.java
ruanwenjun
requested changes
Apr 15, 2026
|
|
||
| public class TaskKillException extends RuntimeException { | ||
|
|
||
| public TaskKillException(String message) { |
|
|
||
| public class TaskPauseException extends RuntimeException { | ||
|
|
||
| public TaskPauseException(String message) { |
|
|
||
| public class TaskReassignMasterHostException extends RuntimeException { | ||
|
|
||
| public TaskReassignMasterHostException(String message) { |
| /** | ||
| * Register a WorkflowInstanceLifecycleListener to the Workflow instance. | ||
| */ | ||
| void registerWorkflowInstanceLifecycleListener(IWorkflowLifecycleListener listener); |
Contributor
Author
There was a problem hiding this comment.
Don't remove this.
ok
| @@ -68,12 +66,6 @@ public List<IWorkflowLifecycleListener> getWorkflowLifecycleListeners() { | |||
| return workflowInstanceLifecycleListeners; | |||
| } | |||
|
|
|||
| @Override | |||
| public void registerWorkflowInstanceLifecycleListener(IWorkflowLifecycleListener listener) { | |||
Contributor
Author
There was a problem hiding this comment.
Don't remove this.
ok
| super(message); | ||
| } | ||
|
|
||
| public LogicTaskInitializeException(String message, Throwable cause) { |
|
|
||
| public class MasterTaskExecuteException extends MasterException { | ||
|
|
||
| public MasterTaskExecuteException(String message) { |
Contributor
Author
There was a problem hiding this comment.
Don't remove this.
ok
added 2 commits
April 15, 2026 10:43
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
NO
Purpose of the pull request
Part of #18056
Brief change log
Clean up unused methods and classes
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md