[Improvement-18056] Clean up unused methods and classes in the dolphinscheduler-task-executor and dolphinscheduler-task-plugin

dolphinscheduler-task-executor/src/main/java/org/apache/dolphinscheduler/task/executor/exceptions/TaskExecutorRuntimeException.java

@@ -23,8 +23,4 @@ public TaskExecutorRuntimeException(String message) {
         super(message);
     }
 
-    public TaskExecutorRuntimeException(String message, Throwable cause) {
-        super(message, cause);
-    }
-
 }

dolphinscheduler-task-plugin/dolphinscheduler-task-aliyunserverlessspark/src/main/java/org/apache/dolphinscheduler/plugin/task/aliyunserverlessspark/AliyunServerlessSparkTaskException.java

@@ -19,10 +19,6 @@
 
 public class AliyunServerlessSparkTaskException extends RuntimeException {
 
-    public AliyunServerlessSparkTaskException() {
-        super();
-    }
-
     public AliyunServerlessSparkTaskException(String message) {
         super(message);
     }

dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java

@@ -19,7 +19,6 @@
 
 import org.apache.dolphinscheduler.common.constants.DateConstants;
 
-import java.time.Duration;
 import java.util.Set;
 import java.util.regex.Pattern;
 
@@ -42,31 +41,17 @@ private TaskConstants() {
     public static final int EXIT_CODE_HARD_KILL = 143;
     public static final String PID = "pid";
 
-    public static final String QUESTION = "?";
-
     public static final String COMMA = ",";
 
     public static final String HYPHEN = "-";
 
-    public static final String SLASH = "/";
-
-    public static final String COLON = ":";
-
     public static final String SPACE = " ";
 
-    public static final String SINGLE_SLASH = "/";
-
-    public static final String DOUBLE_SLASH = "//";
-
     public static final String SINGLE_QUOTES = "'";
     public static final String DOUBLE_QUOTES = "\"";
 
-    public static final String SEMICOLON = ";";
-
     public static final String EQUAL_SIGN = "=";
 
-    public static final String UNDERLINE = "_";
-
     /**
      * sleep time
      */
@@ -77,13 +62,6 @@ private TaskConstants() {
     public static final int EXIT_CODE_SUCCESS = 0;
     public static final int RUNNING_CODE = 1;
 
-    public static final String SH = "sh";
-
-    /**
-     * log flush interval?output when reach the interval
-     */
-    public static final int DEFAULT_LOG_FLUSH_INTERVAL = 1000;
-
     /**
      * pstree, get pud and sub pid
      */
@@ -107,16 +85,6 @@ private TaskConstants() {
      */
     public static final String PARAMETER_DATETIME = DateConstants.PARAMETER_DATETIME;
 
-    /**
-     * system date(yyyymmdd) today
-     */
-    public static final String PARAMETER_CURRENT_DATE = DateConstants.PARAMETER_CURRENT_DATE;
-
-    /**
-     * system date(yyyymmdd) yesterday
-     */
-    public static final String PARAMETER_BUSINESS_DATE = DateConstants.PARAMETER_BUSINESS_DATE;
-
     /**
      * the absolute path of current executing task
      */
@@ -194,7 +162,6 @@ private TaskConstants() {
     public static final String SUBTRACT_STRING = "-";
     public static final String LOCAL_PARAMS_LIST = "localParamsList";
     public static final String TASK_TYPE = "taskType";
-    public static final String QUEUE = "queue";
     public static final int DEFAULT_DISPLAY_ROWS = 10;
 
     public static final String JAR = "jar";
@@ -216,8 +183,6 @@ private TaskConstants() {
     public static final String HADOOP_SECURITY_AUTHENTICATION_STARTUP_STATE =
             "hadoop.security.authentication.startup.state";
 
-    public static final String TASK_TYPE_DATA_QUALITY = "DATA_QUALITY";
-
     public static final Set<String> TASK_TYPE_SET_K8S = Sets.newHashSet("K8S", "KUBEFLOW");
 
     /**
@@ -242,7 +207,6 @@ private TaskConstants() {
     public static final String TASK_INSTANCE_ID = "taskInstanceId";
     public static final String MI = "Mi";
     public static final int JOB_TTL_SECONDS = 300;
-    public static final int LOG_LINES = 500;
     public static final String NAMESPACE_NAME = "name";
     public static final String CLUSTER = "cluster";
 
@@ -256,9 +220,6 @@ private TaskConstants() {
      */
     public static final String CONDA_PATH = "conda.path";
 
-    // Loop task constants
-    public static final Duration DEFAULT_LOOP_STATUS_INTERVAL = Duration.ofSeconds(5L);
-
     /**
      * sql params regex
      */
@@ -281,6 +242,6 @@ private TaskConstants() {
     public static final String WORKFLOW_INSTANCE_ID_MDC_KEY = "workflowInstanceId";
     public static final String TASK_INSTANCE_ID_MDC_KEY = "taskInstanceId";
 
-    public static final String STAR = "*";
     public static final String SENSITIVE_DATA_MASK = "******";
+
 }

dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/am/KubernetesApplicationManager.java

@@ -51,7 +51,6 @@
 public class KubernetesApplicationManager implements ApplicationManager<KubernetesApplicationManagerContext> {
 
     private static final String PENDING = "Pending";
-    private static final String RUNNING = "Running";
     private static final String FINISH = "Succeeded";
     private static final String FAILED = "Failed";
     private static final String UNKNOWN = "Unknown";

dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/TaskExecutionStatus.java

@@ -58,10 +58,6 @@ public static TaskExecutionStatus of(int code) {
         return taskExecutionStatus;
     }
 
-    public boolean isRunning() {
-        return this == RUNNING_EXECUTION;
-    }
-
     public boolean isSuccess() {
         return this == TaskExecutionStatus.SUCCESS;
     }
@@ -86,17 +82,6 @@ public boolean isFinished() {
         return isSuccess() || isKill() || isFailure() || isPause() || isForceSuccess();
     }
 
-    public boolean isNeedFaultTolerance() {
-        return this == NEED_FAULT_TOLERANCE;
-    }
-
-    public boolean shouldFailover() {
-        return SUBMITTED_SUCCESS == this
-                || DISPATCH == this
-                || RUNNING_EXECUTION == this
-                || DELAY_EXECUTION == this;
-    }
-
     @EnumValue
     private final int code;
     private final String desc;

dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/TaskTimeoutParameter.java

@@ -55,13 +55,6 @@ public void setInterval(int interval) {
         this.interval = interval;
     }
 
-    public TaskTimeoutParameter() {
-    }
-
-    public TaskTimeoutParameter(boolean enable) {
-        this.enable = enable;
-    }
-
     public TaskTimeoutParameter(boolean enable, TaskTimeoutStrategy strategy, int interval) {
         this.enable = enable;
         this.strategy = strategy;

dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/PropertyPlaceholderHelper.java

@@ -56,16 +56,6 @@ public class PropertyPlaceholderHelper {
 
     private final boolean ignoreUnresolvablePlaceholders;
 
-    /**
-     * Creates a new {@code PropertyPlaceholderHelper} that uses the supplied prefix and suffix.
-     * Unresolvable placeholders are ignored.
-     * @param placeholderPrefix the prefix that denotes the start of a placeholder
-     * @param placeholderSuffix the suffix that denotes the end of a placeholder
-     */
-    public PropertyPlaceholderHelper(String placeholderPrefix, String placeholderSuffix) {
-        this(placeholderPrefix, placeholderSuffix, null, true);
-    }
-
     /**
      * Creates a new {@code PropertyPlaceholderHelper} that uses the supplied prefix and suffix.
      * @param placeholderPrefix the prefix that denotes the start of a placeholder
@@ -92,24 +82,6 @@ public PropertyPlaceholderHelper(String placeholderPrefix, String placeholderSuf
         this.ignoreUnresolvablePlaceholders = ignoreUnresolvablePlaceholders;
     }
 
-    /**
-     * Replaces all placeholders of format {@code ${name}} with the corresponding
-     * property from the supplied {@link Properties}.
-     * @param value the value containing the placeholders to be replaced
-     * @param properties the {@code Properties} to use for replacement
-     * @return the supplied value with placeholders replaced inline
-     */
-    public String replacePlaceholders(String value, final Properties properties) {
-        notNull(properties, "'properties' must not be null");
-        return replacePlaceholders(value, new PlaceholderResolver() {
-
-            @Override
-            public String resolvePlaceholder(String placeholderName) {
-                return properties.getProperty(placeholderName);
-            }
-        });
-    }
-
     /**
      * Replaces all placeholders of format {@code ${name}} with the value returned
      * from the supplied {@link PlaceholderResolver}.

dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/ArgsUtils.java

@@ -17,8 +17,6 @@
 
 package org.apache.dolphinscheduler.plugin.task.api.utils;
 
-import static org.apache.dolphinscheduler.plugin.task.api.TaskConstants.SINGLE_QUOTES;
-
 public class ArgsUtils {
 
     private ArgsUtils() throws IllegalStateException {
@@ -29,8 +27,4 @@ public static String escape(String arg) {
         return arg.replace(" ", "\\ ").replace("\"", "\\\"").replace("'", "\\'");
     }
 
-    public static String wrapperSingleQuotes(String value) {
-        return SINGLE_QUOTES + value + SINGLE_QUOTES;
-    }
-
 }

dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/K8sUtils.java

@@ -17,14 +17,9 @@
 
 package org.apache.dolphinscheduler.plugin.task.api.utils;
 
-import static org.apache.dolphinscheduler.plugin.task.api.TaskConstants.LOG_LINES;
-
 import org.apache.dolphinscheduler.plugin.task.api.TaskException;
 
-import java.util.List;
-
 import lombok.extern.slf4j.Slf4j;
-import io.fabric8.kubernetes.api.model.Pod;
 import io.fabric8.kubernetes.api.model.batch.v1.Job;
 import io.fabric8.kubernetes.client.Config;
 import io.fabric8.kubernetes.client.KubernetesClient;
@@ -83,27 +78,6 @@ public Watch createBatchJobWatcher(String jobName, Watcher<Job> watcher) {
         }
     }
 
-    public String getPodLog(String jobName, String namespace) {
-        try {
-            List<Pod> podList = client.pods().inNamespace(namespace).list().getItems();
-            String podName = null;
-            for (Pod pod : podList) {
-                podName = pod.getMetadata().getName();
-                if (podName.contains("-") && jobName.equals(podName.substring(0, podName.lastIndexOf("-")))) {
-                    break;
-                }
-            }
-            return client.pods().inNamespace(namespace)
-                    .withName(podName)
-                    .tailingLines(LOG_LINES)
-                    .getLog(Boolean.TRUE);
-        } catch (Exception e) {
-            log.error("fail to getPodLog", e);
-            log.error("response bodies : {}", e.getMessage());
-        }
-        return null;
-    }
-
     public void buildClient(String configYaml) {
         try {
             Config config = Config.fromKubeconfig(configYaml);

dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/VarPoolUtils.java

@@ -101,15 +101,6 @@ public List<Property> mergeVarPool(List<List<Property>> varPools) {
         return new ArrayList<>(result.values());
     }
 
-    public String subtractVarPoolJson(String varPool, List<String> subtractVarPool) {
-        List<Property> varPoolList = deserializeVarPool(varPool);
-        List<List<Property>> subtractVarPoolList = subtractVarPool.stream()
-                .map(VarPoolUtils::deserializeVarPool)
-                .collect(Collectors.toList());
-        List<Property> finalVarPool = subtractVarPool(varPoolList, subtractVarPoolList);
-        return JSONUtils.toJsonString(finalVarPool);
-    }
-
     /**
      * Return the subtracted varpool, which key is in varPool but not in subtractVarPool.
      */

dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/main/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyTaskException.java

@@ -22,15 +22,8 @@
  */
 public class DinkyTaskException extends RuntimeException {
 
-    public DinkyTaskException() {
-        super();
-    }
-
     public DinkyTaskException(String message) {
         super(message);
     }
 
-    public DinkyTaskException(String message, Throwable cause) {
-        super(message, cause);
-    }
 }

dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkConstants.java

@@ -55,12 +55,8 @@ private FlinkConstants() {
     public static final String FLINK_TASK_MANAGE_MEM = "-ytm";
     public static final String FLINK_MAIN_CLASS = "-c";
     public static final String FLINK_PARALLELISM = "-p";
-    public static final String FLINK_SHUTDOWN_ON_ATTACHED_EXIT = "-sae";
     public static final String FLINK_PYTHON = "-py";
     public static final String FLINK_SAVEPOINT = "savepoint";
-    public static final String FLINK_METRICS = "metrics";
-    public static final String FLINK_OVERVIEW = "overview";
-    public static final String FLINK_JOBS = "jobs";
     public static final String FLINK_CANCEL = "cancel";
     // For Flink SQL
     public static final String FLINK_FORMAT_EXECUTION_TARGET = "set execution.target=%s";