[Opt](cloud-mow) BE can limit the size of get_delete_bitmap response roughly
#55712
+598
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bobhan1
force-pushed
the
batch-get-delete-bitmap
branch
3 times, most recently
from
3f55931 to
50ed63c
Compare
bobhan1
requested review from
gavinchou,
dataroaring and
w41ter
as code owners
|
run buildall |
gavinchou
reviewed
Sep 5, 2025
| return Status::OK(); | ||
| } | ||
|
|
||
| Status CloudMetaMgr::_get_delete_bitmap_from_ms_by_batch(GetDeleteBitmapRequest& req, |
There was a problem hiding this comment.
add a UT for this function
TPC-H: Total hot run time: 34306 ms |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 186808 ms |
ClickBench: Total hot run time: 30.82 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
reviewed
Sep 5, 2025
| if (!has_more) { | ||
| break; | ||
| } | ||
| LOG_INFO("batch get delete bitmap, progress={}/{}", finished_rowset_ids.size(), |
There was a problem hiding this comment.
also print current bytes of deletebitmap fetched?
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
bobhan1
force-pushed
the
batch-get-delete-bitmap
branch
from
50ed63c to
16b5bc4
Compare
|
run buildall |
github-actions
bot
removed
the
approved
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 35357 ms |
TPC-DS: Total hot run time: 188154 ms |
ClickBench: Total hot run time: 30.81 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
FE UT Coverage ReportIncrement line coverage `` 🎉 |
TPC-H: Total hot run time: 34983 ms |
TPC-DS: Total hot run time: 188995 ms |
ClickBench: Total hot run time: 30.56 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
Sep 18, 2025
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add BE conf
get_delete_bitmap_bytes_thresholdto limit the delete bitmap size inget_delete_bitmapreponse. The MS will return the current results to BE immediately when the size of delete bitmap fetched from fdb in MS reached this theshold the first time, and BE will make subsequent RPCs to get the remaining rowsets' results.This feature is used to reduce the pressure of MS when there are large delete bitmaps stored in fdb.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)