-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[bugfix](compaction) the avg segment size should always be less than input rows #55713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 34179 ms
|
TPC-DS: Total hot run time: 187276 ms
|
ClickBench: Total hot run time: 30.21 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…input rows (apache#55713) ### What problem does this PR solve? If the input rows ==0 and the vertical_compaction_max_segment_size == 40g, the return value is 40g rows, it is larger than int32.max value, so that it will core. But actually, the avg segment rows is always less or equal than the input rows num.
What problem does this PR solve?
If the input rows ==0 and the vertical_compaction_max_segment_size == 40g, the return value is 40g rows, it is larger than int32.max value, so that it will core.
But actually, the avg segment rows is always less or equal than the input rows num.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)