Skip to content

[chore](pipeline) enable ssd storage type for fdb #55722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2025
Merged

[chore](pipeline) enable ssd storage type for fdb #55722

merged 1 commit into from
Sep 6, 2025

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Sep 5, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@w41ter
Copy link
Contributor Author

w41ter commented Sep 5, 2025

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

hello-stephen
hello-stephen approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@hello-stephen hello-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 34111 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 612f389a7c2e2e1ccb4ae12594d053edd93faf56, data reload: false

------ Round 1 ----------------------------------
q1	17601	5182	5033	5033
q2	2004	339	258	258
q3	10176	1319	725	725
q4	10235	1025	534	534
q5	7554	2493	2354	2354
q6	184	170	137	137
q7	923	752	636	636
q8	9364	1356	1075	1075
q9	6978	5114	5205	5114
q10	6903	2403	1953	1953
q11	499	311	280	280
q12	349	382	233	233
q13	17799	3641	3048	3048
q14	239	248	235	235
q15	553	511	498	498
q16	427	436	374	374
q17	584	864	359	359
q18	7831	7160	7085	7085
q19	1241	954	567	567
q20	348	343	230	230
q21	3860	3202	2376	2376
q22	1089	1048	1007	1007
Total cold run time: 106741 ms
Total hot run time: 34111 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5155	5172	5145	5145
q2	261	336	231	231
q3	2186	2700	2281	2281
q4	1368	1781	1346	1346
q5	4230	4468	4549	4468
q6	221	177	133	133
q7	2076	2045	1814	1814
q8	2643	2551	2600	2551
q9	7471	7618	7311	7311
q10	3116	3341	3125	3125
q11	571	509	497	497
q12	697	816	676	676
q13	3458	3932	3271	3271
q14	308	316	280	280
q15	524	501	490	490
q16	501	526	469	469
q17	1220	1562	1380	1380
q18	8028	7723	7615	7615
q19	844	841	895	841
q20	2032	2069	1908	1908
q21	5153	4605	4537	4537
q22	1106	1104	996	996
Total cold run time: 53169 ms
Total hot run time: 51365 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187481 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 612f389a7c2e2e1ccb4ae12594d053edd93faf56, data reload: false

query1	1079	421	402	402
query2	6557	1755	1727	1727
query3	6758	242	229	229
query4	26243	23428	23323	23323
query5	4427	627	508	508
query6	329	252	252	252
query7	4658	511	305	305
query8	314	269	255	255
query9	8584	2925	2908	2908
query10	515	350	327	327
query11	15840	15505	14674	14674
query12	187	119	119	119
query13	1670	558	434	434
query14	9599	6004	5903	5903
query15	219	200	169	169
query16	7671	653	519	519
query17	1260	748	622	622
query18	2038	442	353	353
query19	203	237	168	168
query20	136	131	123	123
query21	225	134	120	120
query22	4154	4146	4121	4121
query23	33901	33141	33176	33141
query24	8100	2376	2394	2376
query25	571	513	464	464
query26	1242	275	170	170
query27	2753	532	353	353
query28	4382	2319	2271	2271
query29	772	608	496	496
query30	309	224	196	196
query31	907	808	729	729
query32	94	85	81	81
query33	613	393	354	354
query34	794	862	550	550
query35	840	847	756	756
query36	988	1043	937	937
query37	131	112	94	94
query38	4078	4107	3961	3961
query39	1532	1419	1425	1419
query40	232	140	129	129
query41	64	66	62	62
query42	132	117	126	117
query43	515	504	481	481
query44	1369	865	881	865
query45	188	184	170	170
query46	884	1026	648	648
query47	1792	1825	1760	1760
query48	386	429	322	322
query49	766	494	409	409
query50	654	694	418	418
query51	4152	4235	4095	4095
query52	121	117	110	110
query53	246	273	213	213
query54	670	624	546	546
query55	105	95	96	95
query56	355	330	343	330
query57	1205	1219	1151	1151
query58	296	283	285	283
query59	2610	2641	2595	2595
query60	378	351	348	348
query61	164	160	166	160
query62	810	736	669	669
query63	230	199	202	199
query64	4418	1213	887	887
query65	4349	4194	4180	4180
query66	1085	450	343	343
query67	15560	15507	15141	15141
query68	5446	944	589	589
query69	501	334	311	311
query70	1197	1122	1132	1122
query71	523	370	321	321
query72	5848	5074	5210	5074
query73	716	672	363	363
query74	9442	9319	8930	8930
query75	3167	3093	2625	2625
query76	3241	1162	755	755
query77	495	415	333	333
query78	9481	9782	8862	8862
query79	1813	855	586	586
query80	710	623	567	567
query81	526	268	228	228
query82	202	147	126	126
query83	277	291	272	272
query84	266	121	107	107
query85	954	558	523	523
query86	483	314	314	314
query87	4286	4255	4198	4198
query88	2921	2247	2227	2227
query89	404	348	297	297
query90	1879	234	225	225
query91	168	174	131	131
query92	95	80	70	70
query93	1210	997	652	652
query94	698	412	323	323
query95	418	345	323	323
query96	493	607	284	284
query97	2608	2720	2569	2569
query98	242	219	309	219
query99	1347	1401	1320	1320
Total cold run time: 270466 ms
Total hot run time: 187481 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.36 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 612f389a7c2e2e1ccb4ae12594d053edd93faf56, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.06
query3	0.25	0.08	0.08
query4	1.63	0.11	0.11
query5	0.46	0.43	0.40
query6	1.19	0.66	0.64
query7	0.03	0.02	0.03
query8	0.05	0.05	0.04
query9	0.59	0.54	0.53
query10	0.59	0.58	0.58
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.62	0.64	0.63
query14	0.78	0.84	0.84
query15	0.89	0.86	0.85
query16	0.39	0.39	0.39
query17	1.06	1.05	1.04
query18	0.22	0.21	0.20
query19	1.92	1.86	1.87
query20	0.02	0.01	0.01
query21	15.40	0.99	0.59
query22	0.76	1.22	0.73
query23	14.90	1.39	0.61
query24	6.90	1.62	1.30
query25	0.50	0.19	0.14
query26	0.57	0.15	0.13
query27	0.07	0.05	0.04
query28	10.67	0.86	0.43
query29	12.60	3.90	3.24
query30	0.28	0.13	0.11
query31	2.83	0.60	0.38
query32	3.23	0.55	0.46
query33	3.06	3.12	3.05
query34	15.99	5.43	4.82
query35	4.91	4.95	4.92
query36	0.70	0.52	0.50
query37	0.11	0.08	0.07
query38	0.06	0.04	0.05
query39	0.04	0.02	0.02
query40	0.18	0.14	0.14
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 105.07 s
Total hot run time: 30.36 s

dataroaring
dataroaring approved these changes Sep 6, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 9097e05 into apache:master Sep 6, 2025
27 of 29 checks passed
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
@w41ter @wenzhenghu
[chore](pipeline) enable ssd storage type for fdb (apache#55722)
7b27dab
@w41ter w41ter deleted the fix/enable_ssd_storage_type_for_cloud_p0 branch September 8, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hello-stephen hello-stephen hello-stephen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@w41ter @hello-stephen @doris-robot @dataroaring