Skip to content

[feat](nereids) support virtual column for StatsDerive #55727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 8, 2025
Merged

[feat](nereids) support virtual column for StatsDerive #55727

merged 5 commits into from
Sep 8, 2025

Conversation

englefly
Copy link
Contributor

@englefly englefly commented Sep 5, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

englefly commented Sep 5, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33859 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 07939ed6bb749ddf6f1ba89893debb7beecb26e9, data reload: false

------ Round 1 ----------------------------------
q1	17616	5222	5051	5051
q2	2008	311	212	212
q3	10288	1291	707	707
q4	10234	1024	533	533
q5	7601	2408	2358	2358
q6	184	167	135	135
q7	906	760	638	638
q8	9349	1356	1133	1133
q9	6845	5134	5164	5134
q10	6945	2374	1956	1956
q11	496	312	290	290
q12	360	363	238	238
q13	17779	3643	2999	2999
q14	225	235	227	227
q15	573	505	480	480
q16	437	434	384	384
q17	598	861	359	359
q18	7356	7100	6921	6921
q19	1313	978	591	591
q20	355	344	233	233
q21	3791	2561	2309	2309
q22	1036	1036	971	971
Total cold run time: 106295 ms
Total hot run time: 33859 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5193	5130	5106	5106
q2	253	349	230	230
q3	2158	2645	2293	2293
q4	1327	1783	1313	1313
q5	4173	4183	4569	4183
q6	222	169	130	130
q7	1997	1989	1814	1814
q8	2702	2543	2628	2543
q9	7362	7268	7248	7248
q10	3140	3335	2862	2862
q11	592	519	508	508
q12	707	742	608	608
q13	3542	3962	3270	3270
q14	298	328	290	290
q15	529	500	472	472
q16	448	508	451	451
q17	1225	1624	1318	1318
q18	7742	7548	7520	7520
q19	846	884	883	883
q20	2038	2036	1890	1890
q21	4875	4361	4262	4262
q22	1069	1041	984	984
Total cold run time: 52438 ms
Total hot run time: 50178 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186320 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 07939ed6bb749ddf6f1ba89893debb7beecb26e9, data reload: false

query1	1077	466	406	406
query2	6556	1720	1646	1646
query3	6774	236	223	223
query4	25746	23224	23320	23224
query5	4401	671	519	519
query6	355	241	232	232
query7	4647	513	306	306
query8	317	255	246	246
query9	8655	2906	2893	2893
query10	516	354	297	297
query11	15870	15009	14716	14716
query12	174	129	114	114
query13	1680	563	424	424
query14	9088	5881	5925	5881
query15	216	191	179	179
query16	7301	659	505	505
query17	1217	742	620	620
query18	2036	434	375	375
query19	207	197	178	178
query20	138	127	123	123
query21	215	130	119	119
query22	4272	4231	4060	4060
query23	33489	32826	32999	32826
query24	8127	2383	2397	2383
query25	590	551	456	456
query26	1257	280	174	174
query27	2711	509	360	360
query28	4412	2231	2186	2186
query29	809	608	492	492
query30	294	239	199	199
query31	929	820	712	712
query32	132	88	80	80
query33	572	414	363	363
query34	808	846	521	521
query35	835	833	751	751
query36	995	1035	907	907
query37	128	113	94	94
query38	4049	4034	3873	3873
query39	1503	1438	1442	1438
query40	223	142	130	130
query41	66	62	65	62
query42	127	118	122	118
query43	525	517	519	517
query44	1394	876	870	870
query45	181	179	166	166
query46	879	1025	659	659
query47	1759	1790	1740	1740
query48	404	451	340	340
query49	792	522	434	434
query50	682	707	411	411
query51	4283	4115	4125	4115
query52	121	117	107	107
query53	255	280	212	212
query54	635	649	542	542
query55	100	90	95	90
query56	356	340	325	325
query57	1176	1202	1133	1133
query58	306	297	285	285
query59	2556	2615	2703	2615
query60	365	358	355	355
query61	171	163	163	163
query62	833	739	659	659
query63	236	201	201	201
query64	4522	1233	830	830
query65	4266	4249	4189	4189
query66	1191	444	355	355
query67	15266	15153	15069	15069
query68	7843	954	583	583
query69	518	339	298	298
query70	1235	1132	1090	1090
query71	534	354	323	323
query72	5694	4982	5003	4982
query73	658	605	360	360
query74	9216	9095	8876	8876
query75	3145	3102	2638	2638
query76	3138	1151	756	756
query77	502	424	347	347
query78	9420	9655	8868	8868
query79	1433	823	593	593
query80	680	623	557	557
query81	488	257	239	239
query82	201	141	119	119
query83	284	285	336	285
query84	256	109	93	93
query85	848	476	429	429
query86	344	322	293	293
query87	4396	4302	4160	4160
query88	2836	2205	2212	2205
query89	392	333	301	301
query90	1988	230	224	224
query91	163	171	128	128
query92	84	175	73	73
query93	1538	996	651	651
query94	707	436	332	332
query95	415	342	322	322
query96	489	600	279	279
query97	2623	2655	2592	2592
query98	245	225	220	220
query99	1327	1404	1311	1311
Total cold run time: 270408 ms
Total hot run time: 186320 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 07939ed6bb749ddf6f1ba89893debb7beecb26e9, data reload: false

query1	0.06	0.04	0.05
query2	0.08	0.05	0.06
query3	0.26	0.09	0.08
query4	1.61	0.12	0.12
query5	0.46	0.45	0.42
query6	1.18	0.64	0.66
query7	0.04	0.03	0.03
query8	0.05	0.05	0.05
query9	0.59	0.53	0.52
query10	0.59	0.58	0.57
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.62	0.62
query14	0.83	0.82	0.83
query15	0.88	0.85	0.86
query16	0.41	0.41	0.43
query17	1.09	1.08	1.05
query18	0.21	0.20	0.20
query19	1.92	1.80	1.78
query20	0.02	0.01	0.01
query21	15.40	0.97	0.61
query22	0.78	1.34	0.80
query23	14.77	1.38	0.62
query24	6.71	1.78	0.52
query25	0.52	0.09	0.14
query26	0.56	0.16	0.14
query27	0.06	0.06	0.05
query28	9.87	0.94	0.44
query29	12.68	3.89	3.31
query30	0.28	0.13	0.11
query31	2.82	0.62	0.39
query32	3.23	0.57	0.50
query33	2.97	3.11	3.08
query34	15.93	5.54	4.87
query35	4.99	4.91	4.88
query36	0.70	0.51	0.50
query37	0.10	0.07	0.08
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.15
query41	0.08	0.04	0.03
query42	0.03	0.03	0.02
query43	0.05	0.03	0.03
Total cold run time: 104.04 s
Total hot run time: 29.77 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 85.71% (12/14) 🎉
Increment coverage report
Complete coverage report

@englefly englefly force-pushed the virtualcolumn-stats branch from 07939ed to 0d743bc Compare September 6, 2025 03:39
@englefly
Copy link
Contributor Author

englefly commented Sep 6, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34506 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ce9d4a5a994943b333368ed5066f18a5071d9650, data reload: false

------ Round 1 ----------------------------------
q1	17654	5452	5071	5071
q2	1983	356	214	214
q3	10244	1315	727	727
q4	10220	1038	537	537
q5	7529	2348	2374	2348
q6	184	167	135	135
q7	923	798	642	642
q8	9348	1351	1103	1103
q9	6954	5110	5149	5110
q10	6935	2360	1937	1937
q11	493	299	274	274
q12	351	359	230	230
q13	17770	3643	3009	3009
q14	240	244	216	216
q15	586	509	489	489
q16	999	1000	938	938
q17	612	860	374	374
q18	7436	7144	6983	6983
q19	1385	954	577	577
q20	333	348	228	228
q21	3924	3174	2381	2381
q22	1065	1041	983	983
Total cold run time: 107168 ms
Total hot run time: 34506 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5181	5070	5107	5070
q2	252	331	232	232
q3	2148	2699	2354	2354
q4	1353	1797	1330	1330
q5	4232	4563	4587	4563
q6	228	173	140	140
q7	2030	2041	1886	1886
q8	2698	2547	2600	2547
q9	7347	7400	7381	7381
q10	3113	3326	2863	2863
q11	587	505	520	505
q12	689	778	653	653
q13	3670	3878	3335	3335
q14	462	321	287	287
q15	518	478	487	478
q16	1078	1110	1082	1082
q17	1161	1484	1447	1447
q18	7892	7658	7673	7658
q19	837	827	996	827
q20	2022	2321	1898	1898
q21	4937	4461	4395	4395
q22	1080	1033	992	992
Total cold run time: 53515 ms
Total hot run time: 51923 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189635 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ce9d4a5a994943b333368ed5066f18a5071d9650, data reload: false

query1	1045	472	405	405
query2	6584	1724	1711	1711
query3	6751	230	222	222
query4	26542	23163	22729	22729
query5	4395	655	532	532
query6	354	248	223	223
query7	4661	522	318	318
query8	329	265	267	265
query9	8673	2974	2996	2974
query10	480	363	307	307
query11	15706	15367	15247	15247
query12	172	130	125	125
query13	1691	569	444	444
query14	10614	9551	9301	9301
query15	217	196	170	170
query16	7793	638	499	499
query17	1226	786	638	638
query18	2040	427	394	394
query19	211	202	172	172
query20	132	138	124	124
query21	212	133	117	117
query22	3966	4211	4087	4087
query23	33987	33044	32831	32831
query24	8192	2391	2390	2390
query25	567	522	455	455
query26	1113	294	171	171
query27	2706	503	365	365
query28	4390	2254	2218	2218
query29	784	611	499	499
query30	296	230	198	198
query31	948	795	771	771
query32	93	90	88	88
query33	581	408	369	369
query34	809	857	534	534
query35	818	824	786	786
query36	997	1029	910	910
query37	130	120	93	93
query38	3536	3532	3546	3532
query39	1517	1594	1416	1416
query40	221	134	125	125
query41	62	61	62	61
query42	129	116	122	116
query43	527	497	491	491
query44	1401	888	873	873
query45	186	174	183	174
query46	865	1015	657	657
query47	1761	1816	1763	1763
query48	411	436	326	326
query49	749	505	430	430
query50	653	706	415	415
query51	3905	3986	3997	3986
query52	124	118	117	117
query53	258	288	206	206
query54	609	610	545	545
query55	109	94	92	92
query56	352	340	329	329
query57	1188	1214	1124	1124
query58	295	289	297	289
query59	2627	2663	2503	2503
query60	384	358	361	358
query61	169	211	161	161
query62	801	726	656	656
query63	239	206	209	206
query64	4418	1150	831	831
query65	4044	3944	4027	3944
query66	1089	444	358	358
query67	15695	15450	15017	15017
query68	7915	929	592	592
query69	490	360	308	308
query70	1361	1296	1245	1245
query71	576	386	328	328
query72	5975	5001	5183	5001
query73	681	679	363	363
query74	9103	9117	8893	8893
query75	3887	3220	2843	2843
query76	3443	1170	766	766
query77	831	410	349	349
query78	9642	9620	8917	8917
query79	2418	814	613	613
query80	665	644	522	522
query81	489	266	229	229
query82	252	170	138	138
query83	267	268	253	253
query84	261	106	96	96
query85	896	460	427	427
query86	392	315	318	315
query87	3710	3755	3683	3683
query88	3830	2287	2242	2242
query89	419	327	303	303
query90	1909	237	235	235
query91	175	178	133	133
query92	96	81	82	81
query93	1907	989	645	645
query94	648	431	316	316
query95	424	336	334	334
query96	502	591	291	291
query97	2879	2968	2891	2891
query98	248	222	212	212
query99	1338	1397	1288	1288
Total cold run time: 276158 ms
Total hot run time: 189635 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.37 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ce9d4a5a994943b333368ed5066f18a5071d9650, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.06
query3	0.25	0.08	0.08
query4	1.61	0.12	0.12
query5	0.26	0.27	0.25
query6	1.18	0.67	0.65
query7	0.04	0.03	0.03
query8	0.05	0.05	0.04
query9	0.64	0.54	0.52
query10	0.58	0.57	0.58
query11	0.17	0.12	0.12
query12	0.16	0.13	0.12
query13	0.64	0.62	0.63
query14	1.04	1.03	1.02
query15	0.89	0.86	0.88
query16	0.41	0.42	0.40
query17	1.04	1.02	1.04
query18	0.22	0.20	0.20
query19	1.97	1.87	1.89
query20	0.02	0.02	0.02
query21	15.42	0.94	0.60
query22	0.75	1.30	0.83
query23	14.76	1.40	0.60
query24	6.27	1.79	0.88
query25	0.55	0.16	0.14
query26	0.65	0.16	0.13
query27	0.06	0.06	0.05
query28	9.52	0.98	0.43
query29	12.56	3.94	3.34
query30	0.30	0.13	0.11
query31	2.83	0.59	0.40
query32	3.25	0.55	0.48
query33	3.07	3.09	3.17
query34	16.05	5.50	4.88
query35	4.93	4.92	4.96
query36	0.69	0.51	0.51
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 103.56 s
Total hot run time: 30.37 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 85.71% (12/14) 🎉
Increment coverage report
Complete coverage report

@englefly
Copy link
Contributor Author

englefly commented Sep 6, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34906 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 908a4e4e839908f7f87fe65120a45a280865eee2, data reload: false

------ Round 1 ----------------------------------
q1	17608	5165	5112	5112
q2	1993	338	225	225
q3	10246	1314	738	738
q4	10237	1030	537	537
q5	7521	2434	2355	2355
q6	193	172	146	146
q7	971	788	616	616
q8	9370	1383	1110	1110
q9	7122	5069	5186	5069
q10	6904	2425	1980	1980
q11	485	304	295	295
q12	357	367	237	237
q13	17783	3691	3068	3068
q14	250	255	226	226
q15	572	511	492	492
q16	1010	1018	952	952
q17	600	874	379	379
q18	7395	7231	7236	7231
q19	1104	968	564	564
q20	357	349	236	236
q21	3788	3157	2343	2343
q22	1058	1030	995	995
Total cold run time: 106924 ms
Total hot run time: 34906 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5174	5199	5100	5100
q2	245	332	228	228
q3	2211	2703	2315	2315
q4	1360	1913	1353	1353
q5	4213	4632	4543	4543
q6	234	178	142	142
q7	2071	2035	1828	1828
q8	2720	2756	2678	2678
q9	7384	7415	7295	7295
q10	3443	3313	2826	2826
q11	576	525	505	505
q12	724	810	647	647
q13	3550	3834	3253	3253
q14	278	386	407	386
q15	538	488	497	488
q16	1047	1104	1108	1104
q17	1201	1597	1378	1378
q18	7948	7780	7528	7528
q19	863	846	898	846
q20	2029	2063	2023	2023
q21	5128	4679	4407	4407
q22	1112	1081	1005	1005
Total cold run time: 54049 ms
Total hot run time: 51878 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189352 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 908a4e4e839908f7f87fe65120a45a280865eee2, data reload: false

query1	1053	484	428	428
query2	6553	1639	1633	1633
query3	6753	232	223	223
query4	26132	23562	23055	23055
query5	4415	665	527	527
query6	344	261	236	236
query7	4666	526	317	317
query8	311	265	268	265
query9	8677	2950	2957	2950
query10	505	360	302	302
query11	15538	14999	14768	14768
query12	184	135	127	127
query13	1697	556	450	450
query14	10609	9321	9153	9153
query15	212	189	168	168
query16	7762	637	478	478
query17	1321	782	613	613
query18	2039	425	341	341
query19	211	200	227	200
query20	133	128	130	128
query21	218	138	118	118
query22	4202	4254	4347	4254
query23	34146	33091	33136	33091
query24	8181	2361	2412	2361
query25	571	519	444	444
query26	1234	279	169	169
query27	2732	513	356	356
query28	4397	2282	2235	2235
query29	778	606	502	502
query30	301	224	195	195
query31	899	814	721	721
query32	95	84	87	84
query33	584	390	356	356
query34	795	859	537	537
query35	812	823	750	750
query36	977	1009	927	927
query37	132	118	94	94
query38	3553	3440	3486	3440
query39	1509	1422	1430	1422
query40	230	142	133	133
query41	69	66	64	64
query42	132	123	125	123
query43	492	522	458	458
query44	1377	884	876	876
query45	186	185	172	172
query46	876	1025	654	654
query47	1791	1822	1784	1784
query48	392	426	323	323
query49	788	528	449	449
query50	673	687	422	422
query51	3986	3889	3920	3889
query52	126	119	111	111
query53	297	270	197	197
query54	610	606	550	550
query55	94	90	94	90
query56	344	336	323	323
query57	1226	1227	1147	1147
query58	290	290	283	283
query59	2680	2704	2530	2530
query60	379	351	333	333
query61	165	154	205	154
query62	816	738	649	649
query63	230	193	194	193
query64	4386	1127	819	819
query65	4041	4003	3963	3963
query66	1112	433	346	346
query67	15745	15484	15036	15036
query68	8505	915	583	583
query69	497	333	287	287
query70	1397	1309	1333	1309
query71	584	353	325	325
query72	6054	5020	5089	5020
query73	749	627	365	365
query74	8980	9062	9021	9021
query75	3955	3240	2786	2786
query76	3707	1182	809	809
query77	816	399	333	333
query78	9568	9761	8880	8880
query79	2848	833	601	601
query80	706	578	519	519
query81	470	261	226	226
query82	468	172	132	132
query83	293	259	269	259
query84	302	113	93	93
query85	854	452	425	425
query86	347	311	313	311
query87	3791	3754	3663	3663
query88	3248	2226	2264	2226
query89	413	326	303	303
query90	1933	225	222	222
query91	164	180	135	135
query92	87	77	71	71
query93	1595	1014	638	638
query94	698	427	314	314
query95	410	347	333	333
query96	490	579	283	283
query97	2929	2976	2887	2887
query98	252	222	226	222
query99	1454	1376	1282	1282
Total cold run time: 277328 ms
Total hot run time: 189352 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 908a4e4e839908f7f87fe65120a45a280865eee2, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.06	0.05
query3	0.26	0.09	0.08
query4	1.60	0.12	0.11
query5	0.27	0.26	0.27
query6	1.18	0.65	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.05
query9	0.62	0.54	0.51
query10	0.58	0.58	0.58
query11	0.16	0.11	0.12
query12	0.16	0.12	0.12
query13	0.63	0.66	0.62
query14	1.03	1.04	1.04
query15	0.87	0.85	0.86
query16	0.40	0.40	0.41
query17	1.04	1.08	1.05
query18	0.21	0.20	0.19
query19	1.87	1.85	1.87
query20	0.02	0.01	0.01
query21	15.40	0.96	0.60
query22	0.79	1.15	0.74
query23	14.88	1.42	0.65
query24	7.04	1.87	1.11
query25	0.51	0.17	0.08
query26	0.62	0.16	0.13
query27	0.05	0.06	0.04
query28	9.80	0.92	0.41
query29	12.61	3.90	3.25
query30	0.29	0.14	0.12
query31	2.83	0.59	0.38
query32	3.23	0.58	0.47
query33	3.09	3.12	3.08
query34	16.09	5.45	4.84
query35	4.98	4.94	4.94
query36	0.72	0.50	0.52
query37	0.11	0.07	0.08
query38	0.07	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 104.6 s
Total hot run time: 30.3 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 85.71% (12/14) 🎉
Increment coverage report
Complete coverage report

yujun777
yujun777 approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

PR approved by anyone and no changes requested.

Jibing-Li
Jibing-Li approved these changes Sep 8, 2025
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalOlapScan.java
operativeCol = " operativeSlots(" + operativeSlots + ")";
}
return Utils.toSqlString("PhysicalOlapScan[" + table.getName() + index + partitions + operativeCol + "]"
// String operativeCol = "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove these comments?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

PR approved by at least one committer and no changes requested.

@hello-stephen hello-stephen merged commit 6fa6f45 into apache:master Sep 8, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jibing-Li Jibing-Li Jibing-Li approved these changes

+1 more reviewer

@yujun777 yujun777 yujun777 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@englefly @hello-stephen @doris-robot @yujun777 @Jibing-Li