Skip to content

branch-3.1: [fix](mysql protocol)Set more stmt exists flag correctly when forwardto master. #55711 #55871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

branch-3.1: [fix](mysql protocol)Set more stmt exists flag correctly when forwardto master. #55711 #55871

merged 1 commit into from
Sep 11, 2025

Conversation

Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Sep 10, 2025 •
edited by morrySnow
Loading

backport: #55711

@Jibing-Li
[fix](mysql protocol)Set more stmt exists flag correctly when forward…
d75663f 
… to master. (apache#55711)

When execute multiple statements in one batch and
CLIENT_MULTI_STATEMENTS is set, Doris server need to set
SERVER_MORE_RESULTS_EXISTS flag in the return packet before the last
statement. But when the Observer forward stmt to Master, this
SERVER_MORE_RESULTS_EXISTS is not set, cause the following statements
failed to execute.
This pr forward a boolean value to Master, so the Master FE knows it is
the last statement or not, and could set SERVER_MORE_RESULTS_EXISTS
correctly.
@Thearas
Copy link
Contributor

Thearas commented Sep 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review September 10, 2025 09:35
@Jibing-Li
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.20% (1233/1500)
Line Coverage 66.11% (22168/33534)
Region Coverage 67.61% (11135/16469)
Branch Coverage 57.20% (5881/10282)

@Jibing-Li
Copy link
Contributor Author

run feut

@doris-robot
Copy link

TPC-H: Total hot run time: 32833 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d75663fe4a8a1bf9196bb38318b7f031169d89a0, data reload: false

------ Round 1 ----------------------------------
q1	17685	5674	5460	5460
q2	2028	412	280	280
q3	12027	1224	744	744
q4	10232	876	459	459
q5	8232	2408	2184	2184
q6	191	164	137	137
q7	907	749	625	625
q8	9350	1471	1191	1191
q9	5296	5018	4897	4897
q10	6771	2266	1817	1817
q11	477	281	268	268
q12	336	349	209	209
q13	17787	3625	3016	3016
q14	236	224	209	209
q15	527	470	457	457
q16	419	433	365	365
q17	608	895	368	368
q18	7074	6399	6439	6399
q19	1698	958	561	561
q20	326	327	200	200
q21	2783	2188	1993	1993
q22	1071	1061	994	994
Total cold run time: 106061 ms
Total hot run time: 32833 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5570	5549	5544	5544
q2	236	327	239	239
q3	2292	2632	2321	2321
q4	1343	1757	1326	1326
q5	4401	5031	4979	4979
q6	176	170	134	134
q7	2075	2008	1818	1818
q8	2668	2823	2732	2732
q9	7303	7260	7220	7220
q10	3040	3293	2713	2713
q11	571	509	497	497
q12	690	759	590	590
q13	3427	3759	3157	3157
q14	274	292	290	290
q15	540	489	470	470
q16	447	487	435	435
q17	1230	1749	1248	1248
q18	7775	7426	7309	7309
q19	808	1079	1131	1079
q20	2044	2040	1877	1877
q21	5318	4838	4561	4561
q22	1072	1058	979	979
Total cold run time: 53300 ms
Total hot run time: 51518 ms

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 15.38% (2/13) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-DS: Total hot run time: 193683 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d75663fe4a8a1bf9196bb38318b7f031169d89a0, data reload: false

query1	939	420	421	420
query2	6285	1972	1890	1890
query3	8686	206	207	206
query4	33545	23914	23602	23602
query5	3634	606	443	443
query6	298	188	171	171
query7	4197	497	328	328
query8	321	262	248	248
query9	9347	2665	2626	2626
query10	492	326	258	258
query11	18351	15581	15506	15506
query12	159	107	108	107
query13	1565	557	445	445
query14	10481	7523	7516	7516
query15	286	196	178	178
query16	8101	681	480	480
query17	1567	778	592	592
query18	2169	412	314	314
query19	278	187	167	167
query20	123	125	125	125
query21	216	137	112	112
query22	4721	4720	4444	4444
query23	35079	33974	33858	33858
query24	7435	2711	2714	2711
query25	551	486	425	425
query26	1247	298	175	175
query27	1999	501	370	370
query28	5234	2256	2211	2211
query29	797	602	481	481
query30	251	192	171	171
query31	997	906	852	852
query32	88	57	66	57
query33	498	353	313	313
query34	737	871	551	551
query35	792	826	772	772
query36	1021	1093	995	995
query37	113	94	70	70
query38	4024	4024	3971	3971
query39	1543	1686	1470	1470
query40	208	120	104	104
query41	48	47	48	47
query42	135	108	108	108
query43	532	538	499	499
query44	1380	851	841	841
query45	184	182	169	169
query46	888	1091	729	729
query47	1956	1932	1944	1932
query48	429	441	364	364
query49	780	502	414	414
query50	709	686	438	438
query51	7227	7407	7209	7209
query52	105	99	95	95
query53	237	265	204	204
query54	566	559	481	481
query55	84	82	85	82
query56	275	284	262	262
query57	1267	1257	1221	1221
query58	238	217	221	217
query59	2998	3111	2992	2992
query60	288	289	255	255
query61	146	135	118	118
query62	795	761	724	724
query63	235	195	194	194
query64	4513	1016	641	641
query65	3359	3298	3335	3298
query66	1002	416	322	322
query67	16539	15992	15739	15739
query68	7433	836	537	537
query69	492	298	257	257
query70	1206	1183	1135	1135
query71	432	293	263	263
query72	5817	3756	3859	3756
query73	642	747	352	352
query74	10767	9358	9125	9125
query75	4011	3152	2675	2675
query76	3521	1180	760	760
query77	787	390	281	281
query78	10404	10301	9643	9643
query79	3271	905	599	599
query80	739	517	430	430
query81	494	256	223	223
query82	580	125	89	89
query83	168	162	149	149
query84	290	103	87	87
query85	771	347	304	304
query86	346	323	293	293
query87	4330	4293	4216	4216
query88	3498	2432	2437	2432
query89	429	342	288	288
query90	1892	191	190	190
query91	139	148	111	111
query92	68	59	52	52
query93	1979	870	535	535
query94	652	417	305	305
query95	346	284	274	274
query96	491	611	290	290
query97	3207	3277	3182	3182
query98	221	213	205	205
query99	1497	1420	1315	1315
Total cold run time: 296210 ms
Total hot run time: 193683 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.54% (12762/28022)
Line Coverage 36.38% (113804/312811)
Region Coverage 34.00% (65068/191372)
Branch Coverage 31.03% (34143/110044)

@doris-robot
Copy link

ClickBench: Total hot run time: 29.38 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d75663fe4a8a1bf9196bb38318b7f031169d89a0, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.24	0.06	0.06
query4	1.64	0.09	0.08
query5	0.52	0.50	0.51
query6	1.13	0.74	0.75
query7	0.02	0.02	0.02
query8	0.05	0.05	0.05
query9	0.57	0.51	0.48
query10	0.56	0.56	0.55
query11	0.18	0.12	0.12
query12	0.16	0.14	0.13
query13	0.61	0.61	0.59
query14	0.78	0.80	0.78
query15	0.86	0.87	0.83
query16	0.39	0.38	0.38
query17	1.06	1.07	1.07
query18	0.19	0.18	0.18
query19	1.97	1.89	1.85
query20	0.02	0.02	0.01
query21	15.37	0.96	0.66
query22	0.76	0.76	0.69
query23	14.82	1.55	0.67
query24	2.18	0.36	0.22
query25	0.14	0.08	0.08
query26	0.29	0.19	0.18
query27	0.08	0.08	0.08
query28	13.45	1.35	0.55
query29	12.64	4.12	3.36
query30	0.26	0.09	0.07
query31	2.83	0.63	0.40
query32	3.22	0.58	0.49
query33	3.02	3.07	3.05
query34	16.53	5.25	4.61
query35	4.57	4.67	4.68
query36	0.63	0.50	0.51
query37	0.19	0.18	0.16
query38	0.16	0.16	0.16
query39	0.06	0.04	0.05
query40	0.17	0.13	0.12
query41	0.09	0.06	0.05
query42	0.06	0.04	0.04
query43	0.04	0.05	0.04
Total cold run time: 102.63 s
Total hot run time: 29.38 s

@Jibing-Li
Copy link
Contributor Author

run cloud_p0

1 similar comment
@Jibing-Li
Copy link
Contributor Author

run cloud_p0

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 66.16% (18233/27560)
Line Coverage 57.78% (180192/311834)
Region Coverage 55.50% (106634/192148)
Branch Coverage 49.81% (55070/110558)

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 66.16% (18233/27560)
Line Coverage 57.78% (180192/311834)
Region Coverage 55.50% (106634/192148)
Branch Coverage 49.81% (55070/110558)

@morrySnow morrySnow changed the title branch-3.1: [fix](mysql protocol)Set more stmt exists flag correctly when forwardto master. (#55711) branch-3.1: [fix](mysql protocol)Set more stmt exists flag correctly when forwardto master. #55711 Sep 11, 2025
@morrySnow morrySnow merged commit 9a283b2 into apache:branch-3.1 Sep 11, 2025
24 of 25 checks passed
@morrySnow morrySnow deleted the forward3.1 branch September 11, 2025 02:39
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jibing-Li @Thearas @hello-stephen @doris-robot @morrySnow