Skip to content

[fix] Check rs meta size during cool down progress #57368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+9 −0
Open

[fix] Check rs meta size during cool down progress #57368

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c4a273
fix core bug
zhaorongsheng Oct 27, 2025
b2921a0
Merge branch 'master' into bugfix_be_core_when_cooldown
zhaorongsheng Oct 27, 2025
65001b7
Refactor logging for empty cooldown meta rs_metas
zhaorongsheng Oct 27, 2025
085f1bd
Merge branch 'master' into bugfix_be_core_when_cooldown
zhaorongsheng Oct 28, 2025
8bcdf70
Merge branch 'master' into bugfix_be_core_when_cooldown
zhaorongsheng Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions be/src/olap/tablet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2273,6 +2273,15 @@ Status Tablet::_follow_cooldowned_data() {
LOG(INFO) << "cannot read cooldown meta: " << st;
return Status::InternalError<false>("cannot read cooldown meta");
}

if (cooldown_meta_pb.rs_metas_size() <= 0) {
LOG(WARNING)
<< "Cooldown meta file exists but rs_metas is empty for tablet " << tablet_id()
<< ". Cooldown meta id: " << cooldown_meta_pb.cooldown_meta_id()
<< ". This may indicate a cooldown meta synchronization issue or an invalid file.";
return Status::InternalError<false>("Cooldown meta rs_metas is empty");
}

DCHECK(cooldown_meta_pb.rs_metas_size() > 0);
if (_tablet_meta->cooldown_meta_id() == cooldown_meta_pb.cooldown_meta_id()) {
// cooldowned rowsets are same, no need to follow
Expand Down