Skip to content

Conversation

@wumeibanfa
Copy link
Contributor

What problem does this PR solve?

Rename StringView to StringContainer

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wumeibanfa
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 27, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-DS: Total hot run time: 190434 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 20f4159544a509f7f1bba651fcb0872014c16d60, data reload: false

query1	1107	411	398	398
query2	6577	1726	1715	1715
query3	6757	222	222	222
query4	26889	23947	23248	23248
query5	4426	636	505	505
query6	343	258	241	241
query7	4647	511	308	308
query8	321	266	254	254
query9	8689	2574	2584	2574
query10	495	344	308	308
query11	15448	15084	14791	14791
query12	194	128	117	117
query13	1686	574	425	425
query14	10357	9312	9392	9312
query15	212	189	177	177
query16	7165	670	531	531
query17	983	771	643	643
query18	2008	431	361	361
query19	223	216	192	192
query20	153	146	143	143
query21	256	143	140	140
query22	4669	4752	4589	4589
query23	34869	34036	33904	33904
query24	8620	2537	2520	2520
query25	602	586	498	498
query26	1249	282	170	170
query27	3078	515	384	384
query28	4575	2268	2274	2268
query29	899	662	556	556
query30	310	251	203	203
query31	911	823	800	800
query32	83	74	76	74
query33	597	390	346	346
query34	834	898	539	539
query35	866	886	805	805
query36	973	1029	959	959
query37	142	122	91	91
query38	3721	3617	3687	3617
query39	1544	1487	1501	1487
query40	229	139	130	130
query41	67	72	68	68
query42	130	116	128	116
query43	532	482	462	462
query44	1214	750	750	750
query45	185	184	175	175
query46	886	989	649	649
query47	1729	1787	1745	1745
query48	396	438	321	321
query49	762	509	397	397
query50	653	684	421	421
query51	3890	4060	3942	3942
query52	111	112	108	108
query53	257	267	195	195
query54	605	612	532	532
query55	88	91	86	86
query56	341	335	318	318
query57	1168	1200	1124	1124
query58	303	282	276	276
query59	2527	2702	2542	2542
query60	356	356	369	356
query61	190	189	190	189
query62	798	758	657	657
query63	245	208	203	203
query64	4609	1190	873	873
query65	4058	3960	3968	3960
query66	1166	434	337	337
query67	15494	15202	14832	14832
query68	8389	885	592	592
query69	504	334	288	288
query70	1323	1235	1246	1235
query71	511	351	316	316
query72	5927	4971	4857	4857
query73	699	577	375	375
query74	9348	8969	8643	8643
query75	4087	3362	2864	2864
query76	3767	1148	728	728
query77	816	402	327	327
query78	9568	9551	8953	8953
query79	2213	811	590	590
query80	639	555	520	520
query81	505	271	232	232
query82	452	167	131	131
query83	271	266	252	252
query84	302	113	92	92
query85	925	492	447	447
query86	386	319	284	284
query87	3686	3784	3638	3638
query88	3757	2251	2246	2246
query89	404	333	293	293
query90	1905	218	212	212
query91	179	165	136	136
query92	81	73	64	64
query93	1725	994	640	640
query94	687	453	347	347
query95	409	324	317	317
query96	495	572	278	278
query97	2977	2989	2862	2862
query98	260	230	218	218
query99	1446	1381	1278	1278
Total cold run time: 279110 ms
Total hot run time: 190434 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.76 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 20f4159544a509f7f1bba651fcb0872014c16d60, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.06	0.05
query3	0.25	0.08	0.08
query4	1.61	0.13	0.12
query5	0.28	0.27	0.26
query6	1.18	0.67	0.63
query7	0.03	0.02	0.02
query8	0.07	0.04	0.04
query9	0.62	0.53	0.52
query10	0.59	0.57	0.58
query11	0.17	0.11	0.11
query12	0.14	0.12	0.13
query13	0.62	0.63	0.62
query14	1.02	1.02	1.02
query15	0.86	0.83	0.86
query16	0.42	0.39	0.38
query17	1.05	1.08	1.03
query18	0.22	0.20	0.20
query19	1.91	1.86	1.76
query20	0.01	0.01	0.01
query21	15.47	0.19	0.13
query22	5.07	0.07	0.05
query23	15.70	0.26	0.10
query24	2.24	0.91	0.66
query25	0.06	0.07	0.06
query26	0.14	0.13	0.13
query27	0.06	0.06	0.05
query28	4.45	1.13	0.94
query29	12.56	4.00	3.28
query30	0.26	0.13	0.12
query31	2.82	0.58	0.37
query32	3.23	0.54	0.46
query33	2.97	3.03	3.17
query34	15.86	5.25	4.56
query35	4.56	4.54	4.56
query36	0.68	0.51	0.49
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.04
query40	0.17	0.16	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 97.89 s
Total hot run time: 27.76 s

@wumeibanfa
Copy link
Contributor Author

run compile

@wumeibanfa
Copy link
Contributor Author

run beut

1 similar comment
@wumeibanfa
Copy link
Contributor Author

run beut

@wumeibanfa
Copy link
Contributor Author

run nonConcurrent

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 90.48% (19/21) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.76% (18055/34221)
Line Coverage 37.99% (163684/430866)
Region Coverage 32.36% (124723/385456)
Branch Coverage 33.73% (54540/161713)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 90.48% (19/21) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.39% (23934/33526)
Line Coverage 57.79% (248878/430648)
Region Coverage 52.97% (206664/390160)
Branch Coverage 54.60% (88713/162478)

@zclllyybb zclllyybb merged commit 65bec81 into apache:master Oct 29, 2025
28 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 29, 2025
Rename StringView to StringContainer because it's a container not a view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants