Reduce number of metadata transaction retries #17808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metadata transactions initiated by
IndexerSQLMetadataStorageCoordinator
andMetadataTaskStorage
typically hold the
TaskLockbox.giant
lock while the transaction is in progress.If there is a transient failure, the transaction is retried up to 10 times which typically spans a period of over 5 minutes.
This eventually leads to a very late failure while causing the Overlord threads to be stuck due to the giant lock.
Changes
This PR has: