Skip to content

fix some resource leak #15743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.3
Choose a base branch
from
+7 −11
Open

fix some resource leak #15743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb3cdbb
fix some resource leak
Oct 28, 2025
6798384
code formatting
Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...-plugin/dubbo-security/src/main/java/org/apache/dubbo/security/cert/DubboCertManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,9 @@ private String generatePrivatePemKey(KeyPair keyPair) throws IOException {
private String generatePemKey(String type, byte[] content) throws IOException {
PemObject pemObject = new PemObject(type, content);
StringWriter str = new StringWriter();
JcaPEMWriter jcaPEMWriter = new JcaPEMWriter(str);
jcaPEMWriter.writeObject(pemObject);
jcaPEMWriter.close();
str.close();
try (JcaPEMWriter jcaPEMWriter = new JcaPEMWriter(str)) {
jcaPEMWriter.writeObject(pemObject);
}
return str.toString();
Comment on lines 370 to 374
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The StringWriter should be included in the try-with-resources statement to ensure it is properly closed. While StringWriter.close() doesn't throw exceptions or manage external resources, following the pattern consistently ensures best practices.

Copilot uses AI. Check for mistakes.
}

Expand Down
11 changes: 4 additions & 7 deletions ...pc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/compressor/Bzip2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,8 @@ public byte[] compress(byte[] payloadByteArr) throws RpcException {
}

ByteArrayOutputStream out = new ByteArrayOutputStream();
BZip2CompressorOutputStream cos;
try {
cos = new BZip2CompressorOutputStream(out);
try (BZip2CompressorOutputStream cos = new BZip2CompressorOutputStream(out)) {
cos.write(payloadByteArr);
cos.close();
} catch (Exception e) {
throw new IllegalStateException(e);
}
Expand All @@ -75,9 +72,9 @@ public byte[] decompress(byte[] payloadByteArr) {
}

ByteArrayOutputStream out = new ByteArrayOutputStream();
ByteArrayInputStream in = new ByteArrayInputStream(payloadByteArr);
try {
BZip2CompressorInputStream unZip = new BZip2CompressorInputStream(in);
try (ByteArrayInputStream in = new ByteArrayInputStream(payloadByteArr);
BZip2CompressorInputStream unZip = new BZip2CompressorInputStream(in)) {

byte[] buffer = new byte[2048];
int n;
while ((n = unZip.read(buffer)) >= 0) {
Expand Down
Loading