Skip to content

Fix: Stabilize JsonUtilsTest.consistentTest to prevent Non-Dex nondeterminism #15746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
+8 −6
Merged

Fix: Stabilize JsonUtilsTest.consistentTest to prevent Non-Dex nondeterminism #15746

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f55224c
Stabilized the test JsonUtilsTest.consistentTest
Anshul-creator Oct 29, 2025
45e2e2d
Merge branch '3.3' into fix-consistentTest
heliang666s Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions dubbo-common/src/test/java/org/apache/dubbo/common/utils/JsonUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import java.util.Map;
import java.util.concurrent.atomic.AtomicBoolean;

import com.fasterxml.jackson.databind.ObjectMapper;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -165,7 +166,8 @@ void testGetJson1() {
}

@Test
void consistentTest() {
void consistentTest() throws Exception {
ObjectMapper om = new ObjectMapper();
List<Object> objs = new LinkedList<>();

{
Expand Down Expand Up @@ -261,11 +263,11 @@ void consistentTest() {

setJson(null);

Assertions.assertEquals(fromFastjson1, fromFastjson2);
Assertions.assertEquals(fromFastjson1, fromGson);
Assertions.assertEquals(fromFastjson2, fromGson);
Assertions.assertEquals(fromFastjson1, fromJackson);
Assertions.assertEquals(fromFastjson2, fromJackson);
Assertions.assertEquals(om.readTree(fromFastjson1), om.readTree(fromFastjson2));
Assertions.assertEquals(om.readTree(fromFastjson1), om.readTree(fromGson));
Assertions.assertEquals(om.readTree(fromFastjson2), om.readTree(fromGson));
Assertions.assertEquals(om.readTree(fromFastjson1), om.readTree(fromJackson));
Assertions.assertEquals(om.readTree(fromFastjson2), om.readTree(fromJackson));
}
}

Expand Down
Loading