Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #4733] e.printStackTrace() with log.error() #4748

Closed
wants to merge 3 commits into from
Closed

[ISSUE #4733] e.printStackTrace() with log.error() #4748

wants to merge 3 commits into from

Conversation

archit-8
Copy link

Fixes #4733

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@archit-8
[ ISSUE #4733]printStackTrace() with log.error()
c9d47a3 
 Replace e.printStackTrace() to log.error()
@archit-8
[ ISSUE #4733 ]Substitute e.printStackTrace() with log.error()
d2ae661 
e.printStackTrace() reomved
@archit-8
[ISSUE #4733] e.printStackTrace() with log.error()
e86468f 
Replaced e.printStackTrace with log.error()
@archit-8
Copy link
Author

@Pil0tXia hey review my changes

@archit-8 archit-8 closed this Jan 16, 2024
@archit-8 archit-8 reopened this Jan 16, 2024
mxsm
mxsm reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archit-8 Please fix ci error

@Alonexc
Copy link
Contributor

Alonexc commented Jan 17, 2024

image

It looks like it should be missing the import of Slf4j.

@archit-8 archit-8 closed this Jan 17, 2024
@archit-8 archit-8 deleted the archit-8-patch-1 branch January 17, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxsm mxsm mxsm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Substitute e.printStackTrace() with log.error()
3 participants
@archit-8 @Alonexc @mxsm