Skip to content

FINERACT-2788: Optimize E2E test execution of WorkingCapitalLoanChargeAfterMaturity.feature - #6359

Open
Cocoa-Puffs wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2788-optimize-working-capital-loan-charge-after-maturity-scenarios
Open

FINERACT-2788: Optimize E2E test execution of WorkingCapitalLoanChargeAfterMaturity.feature#6359
Cocoa-Puffs wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2788-optimize-working-capital-loan-charge-after-maturity-scenarios

Conversation

@Cocoa-Puffs

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@Cocoa-Puffs
Cocoa-Puffs force-pushed the FINERACT-2788-optimize-working-capital-loan-charge-after-maturity-scenarios branch from 259b8c6 to b6b9f13 Compare August 31, 2026 10:20
@budaidev

Copy link
Copy Markdown
Contributor

Note: Overall it is a good improvement and optimization for the tests. However the previous UC1 and UC4 cases added charges several months after disbursement and asserted three or five breach periods. The new January 6 due date is inside the first period, which spans January 1 through February 28, so the schedule does not need to be extended at all. This means that a regression that fails to generate intervening breach periods or fails to extend a schedule to a later charge date could pass this feature undetected.

@Cocoa-Puffs
Cocoa-Puffs force-pushed the FINERACT-2788-optimize-working-capital-loan-charge-after-maturity-scenarios branch from b6b9f13 to c7c00ff Compare August 31, 2026 11:08
@Cocoa-Puffs

Cocoa-Puffs commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Note: Overall it is a good improvement and optimization for the tests. However the previous UC1 and UC4 cases added charges several months after disbursement and asserted three or five breach periods. The new January 6 due date is inside the first period, which spans January 1 through February 28, so the schedule does not need to be extended at all. This means that a regression that fails to generate intervening breach periods or fails to extend a schedule to a later charge date could pass this feature undetected.

I have modified UC1 and UC4 so they again test the behaviour of a post-maturity charge extending the schedules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants