FINERACT-2796: Add coverage for release build - #6361
Open
meonkeys wants to merge 4 commits into
Open
Conversation
Adds a parallel CI job that runs generateLicenseReport, srcDistTar, and binaryDistTar against every commit to develop, so regressions in the release packaging tasks are caught before release time instead of during manual release prep. Runs alongside the other post-build-core jobs so it doesn't add to overall CI wall-clock time, and skips checks/tests already covered by dedicated jobs (test, cucumber, rat, checkstyle, spotbugs, spotless) to avoid duplicating that work. Assisted-By: claude:sonnet-5
build-documentation.yml ran `./gradlew doc` standalone, but that same doc task is already a transitive dependency of binaryDistTar (fineract-war/build.gradle), which build-release-artifacts.yml runs. Keeping both duplicated the asciidoctor/PDF toolchain setup (node/vega-cli/ghostscript/graphviz) and its runtime across two parallel jobs for no added coverage. Folds the doc-toolchain setup into build-release-artifacts.yml (no change needed to the gradle invocation itself, since binaryDistTar already exercises the doc task) and removes the now-redundant build-documentation.yml. Also splits the license-report and dist-tarball gradle invocations into separate steps, matching the documented release process (fineract-doc/src/docs/en/chapters/release/process-step06.adoc) which runs them as separate `./gradlew` invocations rather than one combined command. Assisted-By: claude:sonnet-5
meonkeys
changed the title
I don't need these saved in CI. When I do the real release build I do it locally.
I guess I excluded too many tasks the first time? It was breaking with many errors like "cannot find symbol" and "package XYZ does not exist"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FINERACT-2796
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!