[FLINK-38079] Add Pipeline support for DateType and TimeType #4060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxiqian
requested changes
Jul 15, 2025
There was a problem hiding this comment.
Thanks for @proletarians' nice work, just left some trivial comments.
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/utils/SchemaMergingUtils.java
Outdated
Show resolved
Hide resolved
...composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineTransformITCase.java
Outdated
Show resolved
Hide resolved
...r-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlFullTypesITCase.java
Outdated
Show resolved
Hide resolved
...ezium/src/main/java/org/apache/flink/cdc/debezium/event/DebeziumSchemaDataTypeInference.java
Outdated
Show resolved
Hide resolved
...-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/data/writer/BinaryWriter.java
Show resolved
Hide resolved
proletarians
force-pushed
the
datetypesupport
branch
from
5a2b834 to
aa96a77
Compare
yuxiqian
force-pushed
the
datetypesupport
branch
from
aa96a77 to
ec18cde
Compare
Mrart
reviewed
Aug 20, 2025
Updated. |
Mrart
reviewed
Aug 21, 2025
...um/src/main/java/org/apache/flink/cdc/debezium/event/DebeziumEventDeserializationSchema.java
Outdated
Show resolved
Hide resolved
...um/src/main/java/org/apache/flink/cdc/debezium/event/DebeziumEventDeserializationSchema.java
Outdated
Show resolved
Hide resolved
yuxiqian
force-pushed
the
datetypesupport
branch
from
5520dd6 to
2dd4f32
Compare
Mrart
reviewed
Aug 22, 2025
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/data/TimeData.java
Show resolved
Hide resolved
|
LGTM |
# Conflicts: # flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineTransformITCase.java # flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/src/test/java/org/apache/flink/cdc/connectors/iceberg/sink/v2/IcebergWriterTest.java
Signed-off-by: yuxiqian <[email protected]>
Signed-off-by: yuxiqian <[email protected]>
Signed-off-by: yuxiqian <[email protected]>
Signed-off-by: yuxiqian <[email protected]>
Signed-off-by: yuxiqian <[email protected]>
lvyanquan
force-pushed
the
datetypesupport
branch
from
2dd4f32 to
a36cf5d
Compare
github-actions
bot
added
composer
common
runtime
e2e-tests
mysql-pipeline-connector
doris-pipeline-connector
starrocks-pipeline-connector
paimon-pipeline-connector
kafka-pipeline-connector
elasticsearch-pipeline-connector
oceanbase-pipeline-connector
maxcompute-pipeline-connector
labels
Signed-off-by: yuxiqian <[email protected]>
|
Just reverted an accidental change that breaks Postgres Pipeline CI, PTAL @lvyanquan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline currently treats DateType and TimeType as plain INT, so date/time columns lose precision (TIME only to milliseconds, DATE range limited) and cannot be used with built-in temporal functions.