-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[FLINK-38206][pipeline-connector][paimon] Support writing to existed table with inconsistent schema with upstream. #4081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…table with inconsistent schema with upstream.
LGTM, but i find some problem in my test. I cherry-picked this to the 3.3 branch and tested the MySQL to Paimon. I'll try to reproduce this tomorrow and figure out the reason. It might be some mistake in my cherry-pick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will let some comment.
...-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PaimonWriterHelper.java
Outdated
Show resolved
Hide resolved
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for @lvyanquan's nice work! Just left some non-blocking comments.
...or-paimon/src/test/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PaimonSinkITCase.java
Outdated
Show resolved
Hide resolved
...or-paimon/src/test/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PaimonSinkITCase.java
Outdated
Show resolved
Hide resolved
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/types/utils/DataTypeUtils.java
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/bucket/BucketAssignOperator.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/bucket/BucketAssignOperator.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/bucket/BucketAssignOperator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
For situations where the structure of downstream tables and upstream data tables is inconsistent, the data is transformed based on the downstream schema to avoid possible errors and data correctness issues.