Add mysql operation metrics #4178
Open
+88
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
Contributor
|
@ruanhang1993 Would you like to help review this PR when you have time? |
nickdelnano
force-pushed
the
nickdelnano/mysql-op-metrics
branch
from
5f889f7 to
2f64f78
Compare
nickdelnano
force-pushed
the
nickdelnano/mysql-op-metrics
branch
from
2f64f78 to
9de8a76
Compare
Author
|
@ruanhang1993 @leonardBang can this PR get a reviewer please? This adds a useful improvement of mysql monitoring that would be great to get in master for all Flink CDC users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mysql table operation metrics. This produces metrics that are useful for monitoring
tabledimension is added with formattable=db_tableI started from the diff of #3529 and added
tabledimension.Testing
This code path is difficult to write thorough tests for. I have deployed it in my environment and confirm it works well. If a reviewer has any suggestions for test cases to add, please let me know.