Skip to content

[FLINK-38600] Fix a race condition in consumer creation by adding a retry with delay #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vbabenkoru wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[FLINK-38600] Fix a race condition in consumer creation by adding a retry with delay #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bacee3
Add partition name to the error message when failing to create a cons…
vbabenkoru Oct 29, 2025
aee6fba
Fix a race condition in the split reader by retrying the subscription…
vbabenkoru Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions ...main/java/org/apache/flink/connector/pulsar/source/reader/PulsarPartitionSplitReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,11 +234,32 @@ public void handleSplitsChanges(SplitsChange<PulsarPartitionSplit> splitsChanges
}
}

// Create pulsar consumer.
// Create pulsar consumer with retry.
try {
this.pulsarConsumer = createPulsarConsumer(registeredSplit.getPartition());
} catch (PulsarClientException e) {
throw new FlinkRuntimeException(e);
LOG.warn("Failed to create consumer on partition {} on first attempt, will retry after 2 seconds",
registeredSplit.getPartition(), e);

try {
Thread.sleep(2000);
} catch (InterruptedException ie) {
Thread.currentThread().interrupt();
throw new FlinkRuntimeException(
String.format("Interrupted while waiting to retry consumer creation on partition %s",
registeredSplit.getPartition()), ie);
}

// Retry consumer creation
try {
this.pulsarConsumer = createPulsarConsumer(registeredSplit.getPartition());
LOG.info("Successfully created consumer on partition {} on second attempt",
registeredSplit.getPartition());
} catch (PulsarClientException retryException) {
throw new FlinkRuntimeException(
String.format("Failed to create consumer on partition %s after retry",
registeredSplit.getPartition()), retryException);
}
}

LOG.info("Register split {} consumer for current reader.", registeredSplit);
Expand Down
Loading