[BP-2.2][FLINK-40683][table] Assert materialized data in the anti-join-on-nested semantic test - #29242
Open
MartijnVisser wants to merge 1 commit into
Open
[BP-2.2][FLINK-40683][table] Assert materialized data in the anti-join-on-nested semantic test#29242MartijnVisser wants to merge 1 commit into
MartijnVisser wants to merge 1 commit into
Conversation
…ted semantic test The sink asserted the raw changelog, so the test failed on the transient +I[test_same] and -D[test_same] that the anti join emits when the probe row arrives before the build row. Master has asserted the materialized result for this program since FLINK-39695, which is master-only. Generated-by: Claude Code (Claude Opus 5)
Collaborator
spuru9
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
JoinSemanticTests[anti-join-on-nested]asserts the raw changelog, so it fails whenever theanti join transiently emits and retracts
+I[test_same]. It failed 6 of the 8 release-2.2Azure nightlies between 2026-09-10 and 2026-09-17, last in
test_cron_jdk21 tableofhttps://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=79135
Brief change log
anti-join-on-nestedsink asserts the materialized result instead of the raw changelog,like the other program in the file
4f8b4a88b1e), which also copiesCalcite classes into the planner and does not belong on a patch branch
Verifying this change
This change is already covered by existing tests, such as
JoinSemanticTests../mvnw -o -pl flink-table/flink-table-planner test -Dtest=JoinSemanticTests, then looped withsurefire:test, JDK 17, under CPUload: 11 of 102 runs failed on
aed108ff0dd, 0 of 100 with this commit appliedNOT EXISTStoEXISTSmakes the patched test fail, so the assertion still catches aregression
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 5)