Skip to content

Commit

Permalink
fix(java): chunk map serialize an error (#2030)
Browse files Browse the repository at this point in the history
<!--
**Thanks for contributing to Fury.**

**If this is your first time opening a PR on fury, you can refer to
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**

Contribution Checklist

- The **Apache Fury (incubating)** community has restrictions on the
naming of pr titles. You can also find instructions in
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).

- Fury has a strong focus on performance. If the PR you submit will have
an impact on performance, please benchmark it first and provide the
benchmark result here.
-->

## What does this PR do?

<!-- Describe the purpose of this PR. -->

fix some error

new implement of map chunk can not pass all of the unit test in the
org.apache.fury.serializer.collection.MapSerializersTest


![image](https://github.com/user-attachments/assets/2af5978d-2ebc-4ad9-9ac2-f90511ed5c59)

![image](https://github.com/user-attachments/assets/edc08cc4-495f-4cbe-9f48-0b8e5bcef10e)
I found an error in line 298 of the AbstractMapSequencer file
## Related issues

<!--
Is there any related issue? Please attach here.
none
- #xxxx0
- #xxxx1
- #xxxx2
-->

## Does this PR introduce any user-facing change?
none
<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fury/issues/new/choose) describing the
need to do so and update the document if necessary.
-->

- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?

## Benchmark
none
<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->

Co-authored-by: hening <[email protected]>
  • Loading branch information
Hen1ng and hening authored Jan 27, 2025
1 parent 4456d2f commit a907a9a
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ private Entry writeJavaChunk(
int chunkSizeOffset = buffer.writerIndex() - 1;
int chunkHeader = 0;
if (keySerializer != null) {
chunkHeader |= VALUE_DECL_TYPE;
chunkHeader |= KEY_DECL_TYPE;
} else {
keySerializer = writeKeyClassInfo(classResolver, keyType, buffer);
}
Expand Down

0 comments on commit a907a9a

Please sign in to comment.