[JavaScript] Support partial record #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see referenceResolver naming, maybe we can name it to 'refResolver' for consistency with other languages |
Good idea, I'll correct it in the next update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
JavaScript is a dynamic language, so the object being serialized may lack certain properties. We should handle partial objects by adding default values for non-referencable types and making the description of object field types optional.
Sometimes, webpack may mock the process object, which can break environment detection. To mitigate this, we can detect the process.version.node property, as it is usually not mocked.
Related issue number
Closes #1207
Check code requirements