Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JavaScript] Improve tag write performance #1241

Merged
merged 9 commits into from
Dec 27, 2023
Merged

[JavaScript] Improve tag write performance #1241

merged 9 commits into from
Dec 27, 2023

Conversation

bytemain
Copy link
Contributor

@bytemain bytemain commented Dec 21, 2023 •
edited
Loading

What do these changes do?

Previously, everytime we write tag, we create new BufferWriter, we alloc new Buffer pool, this is no need.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@bytemain bytemain requested a review from theweipeng as a code owner December 21, 2023 03:48
theweipeng
theweipeng approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@theweipeng theweipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@theweipeng theweipeng merged commit dd2f24a into apache:main Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theweipeng theweipeng theweipeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bytemain @theweipeng