[Java] fix nested collection num elements #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nandakumar131 Could you help review this PR? |
theweipeng
approved these changes
Jan 5, 2024
theweipeng
pushed a commit
to theweipeng/fury
that referenced
this pull request
Jan 6, 2024
Closes apache#1305 Nested collection outer deserialization may read `num elements` for internal collection, which will make deserialization fail. Currently only `StringKeyMapSerializer` has this bug, but future customized may have this issue. This PR make `num elements` defensive from such cases by using a read and reset pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1305
Nested collection outer deserialization may read
num elementsfor internal collection, which will make deserialization fail.Currently only
StringKeyMapSerializerhas this bug, but future customized may have this issue. This PR makenum elementsdefensive from such cases by using a read and reset pattern.