Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(JavaScript): Make PlatformBuffer available if has Buffer polyfill #1373

Merged
merged 6 commits into from
Feb 19, 2024
Merged

feat(JavaScript): Make PlatformBuffer available if has Buffer polyfill #1373

merged 6 commits into from
Feb 19, 2024

Conversation

bytemain
Copy link
Contributor

@bytemain bytemain commented Feb 18, 2024

If user has a polyfill(process/buffer) in browser, furyjs cannot work.

@bytemain bytemain requested a review from theweipeng as a code owner February 18, 2024 10:06
Copy link
Member

@theweipeng theweipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theweipeng theweipeng merged commit c2238b7 into apache:main Feb 19, 2024
30 checks passed
axs[1].set_xlabel("Operation Type")
axs[1].set_xticklabels(["browser write", "native write"])

# 在柱形图上添加数值标签
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change those comments to english?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will send a pr later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants