fix(java): Blacklist detection is also performed when the Class is registered. #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gistered. 1. When a Class has been registered using `Fury#register`, it currently escapes blacklist detection, so correct it to always perform blacklist detection. 2. `FuryBuilder#suppressClassRegistrationWarnings` should remain the same as `FuryBuilder#requireClassRegistration`. The warning log will only be suppressed when `requireClassRegistration` is true, that is, it will only be output when `requireClassRegistration` is not turned on and the Class is not registered. 3. Integrate some code into `isSecure()`. Signed-off-by: LiangliangSui <[email protected]>
LiangliangSui
force-pushed
the
sll
branch
6 times, most recently
from
f067ff0 to
8995197
Compare
chaokunyang
reviewed
Mar 8, 2024
java/fury-core/src/main/java/org/apache/fury/config/FuryBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: LiangliangSui <[email protected]>
chaokunyang
reviewed
Mar 8, 2024
Signed-off-by: LiangliangSui <[email protected]>
chaokunyang
reviewed
Mar 9, 2024
chaokunyang
approved these changes
Mar 9, 2024
Signed-off-by: LiangliangSui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Class has been registered using
Fury#register, it currently escapes blacklist detection, so correct it to always perform blacklist detection.FuryBuilder#suppressClassRegistrationWarningsshould remain the same asFuryBuilder#requireClassRegistration. The warning log will only be suppressed whenrequireClassRegistrationis true, that is, it will only be output whenrequireClassRegistrationis not turned on and the Class is not registered.Integrate some code into
isSecure().