-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(java): zstd meta compressor #2042
Changes from 5 commits
2de4407
59645e9
2c433d4
cafdaec
c78a006
be83d4b
d1a2930
5348a98
6e5e408
db549c9
4dd6099
a1f4359
e7f2b91
fb72a67
1b974f2
5e40b68
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.fury.meta; | ||
|
||
import com.github.luben.zstd.Zstd; | ||
import com.github.luben.zstd.ZstdException; | ||
|
||
public class ZstdMetaCompressor implements MetaCompressor { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we add a test with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you mean this? |
||
|
||
@Override | ||
public byte[] compress(byte[] data, int offset, int size) { | ||
|
||
long maxCompressedSize = Zstd.compressBound(size); | ||
if (maxCompressedSize > Integer.MAX_VALUE) { | ||
throw new ZstdException(Zstd.errGeneric(), "Max output size is greater than MAX_INT"); | ||
} | ||
|
||
byte[] compressedData = new byte[(int) maxCompressedSize]; | ||
Zstd.compressByteArray( | ||
compressedData, | ||
0, | ||
(int) maxCompressedSize, | ||
data, | ||
offset, | ||
size, | ||
Zstd.defaultCompressionLevel()); | ||
|
||
return compressedData; | ||
} | ||
|
||
@Override | ||
public byte[] decompress(byte[] data, int offset, int size) { | ||
int decompressedSize = (int) Zstd.getFrameContentSize(data, offset, size, false); | ||
byte[] decompressedBytes = new byte[decompressedSize]; | ||
Zstd.decompressByteArray(decompressedBytes, 0, decompressedSize, data, offset, size); | ||
return decompressedBytes; | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return ZstdMetaCompressor.class.hashCode(); | ||
} | ||
|
||
@Override | ||
public boolean equals(Object o) { | ||
if (this == o) { | ||
return true; | ||
} | ||
return o != null && getClass() == o.getClass(); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we use
povided
dependency?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im quite new to maven. ive made changes in the new commit, is it suffice?
d1a2930
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, d1a2930 is OK. Could you remove
zstd-jni
from fury-core module, it's used in fury-extensionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops forgot to remove that. Done