[#6716] improvement(authz): Delete catalogs if failing to execute post hook actions #6717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
changed the title
yuqi1129
reviewed
Mar 19, 2025
...anger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Mar 19, 2025
yuqi1129
reviewed
Mar 19, 2025
| if (ClientResponse.Status.NOT_FOUND.equals(rse.getStatus())) { | ||
| if (Boolean.parseBoolean( | ||
| config.get(RangerAuthorizationProperties.RANGER_SERVICE_CREATE_IF_ABSENT)) | ||
| && ClientResponse.Status.NOT_FOUND.equals(rse.getStatus())) { |
There was a problem hiding this comment.
You have changed the original design:
Before: If RANGER_SERVICE_CREATE_IF_ABSENT is false, there will be no exception in any condition.
Now: If RANGER_SERVICE_CREATE_IF_ABSENT is false and the service is unavailable, you will throw
throw new AuthorizationPluginException(
"Fail to get ranger service name %s, exception: %s", serviceName, rse.getMessage());There was a problem hiding this comment.
Yes, the change seems more reasonable for me.
There was a problem hiding this comment.
@xunliu, could you please help confirm the original design?
xunliu
reviewed
Mar 20, 2025
Comment on lines
+242
to
+261
| Map<String, String> wrongProperties = | ||
| ImmutableMap.of( | ||
| HiveConstants.METASTORE_URIS, | ||
| HIVE_METASTORE_URIS, | ||
| IMPERSONATION_ENABLE, | ||
| "true", | ||
| AUTHORIZATION_PROVIDER, | ||
| "ranger", | ||
| RangerAuthorizationProperties.RANGER_SERVICE_TYPE, | ||
| "HadoopSQL", | ||
| RangerAuthorizationProperties.RANGER_ADMIN_URL, | ||
| RangerITEnv.RANGER_ADMIN_URL, | ||
| RangerAuthorizationProperties.RANGER_AUTH_TYPE, | ||
| RangerContainer.authType, | ||
| RangerAuthorizationProperties.RANGER_USERNAME, | ||
| RangerContainer.rangerUserName, | ||
| RangerAuthorizationProperties.RANGER_PASSWORD, | ||
| RangerContainer.rangerPassword, | ||
| RangerAuthorizationProperties.RANGER_SERVICE_CREATE_IF_ABSENT, | ||
| "true"); |
There was a problem hiding this comment.
I remove the service name. This service name is required.
There was a problem hiding this comment.
Please add a comment in the here. Thanks
Comment on lines
264
to
272
| Assertions.assertThrows( | ||
| RuntimeException.class, | ||
| () -> | ||
| metalake.createCatalog( | ||
| "wrongTestProperties", | ||
| Catalog.Type.RELATIONAL, | ||
| provider, | ||
| "comment", | ||
| wrongProperties)); |
There was a problem hiding this comment.
I think it is better to add a check throw type or throw message function.
xunliu
reviewed
Mar 20, 2025
...anger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java
Show resolved
Hide resolved
xunliu
approved these changes
Mar 20, 2025
| if (ClientResponse.Status.NOT_FOUND.equals(rse.getStatus())) { | ||
| if (Boolean.parseBoolean( | ||
| config.get(RangerAuthorizationProperties.RANGER_SERVICE_CREATE_IF_ABSENT)) | ||
| && ClientResponse.Status.NOT_FOUND.equals(rse.getStatus())) { |
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Mar 21, 2025
…te post hook actions (apache#6717) ### What changes were proposed in this pull request? Delete catalogs if failing to execute post hook actions ### Why are the changes needed? Fix: apache#6716 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add a new IT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Delete catalogs if failing to execute post hook actions
Why are the changes needed?
Fix: #6716
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add a new IT.