HBASE-28158 Decouple RIT list management from TRSP #7375
+320
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Umeshkumar9414
force-pushed
the
HBASE-28158_2
branch
from
af75dcb to
99caa2c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
apurtell
reviewed
Oct 14, 2025
...erver/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionInTransitionTracker.java
Show resolved
Hide resolved
| return regionInTransitionTracker.isRegionInTransition(regionInfo); | ||
| } | ||
|
|
||
| public int getOngoingTRSPCount() { |
There was a problem hiding this comment.
Call it getInTransitCount()?
There was a problem hiding this comment.
"Transit" means something different than "in transition". Javadoc the explaination.
There was a problem hiding this comment.
how about scheduledRegionTransition ?
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public boolean isInTransition() { | ||
| public boolean isOngoingTRSP() { |
There was a problem hiding this comment.
How about isInTransit?
And javadoc that "transit" means something different than "in transition".
There was a problem hiding this comment.
how about changing to isTransitionScheduled?
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
Outdated
Show resolved
Hide resolved
| removeRegionInTransition(regionInfo); | ||
| } | ||
|
|
||
| private List<RegionState.State> getExceptedRegionStates(RegionStateNode regionStateNode) { |
There was a problem hiding this comment.
I think this method should be renamed and the code should be documented with comments. You are not really "excepting" regions.
You are basically waiting for the assignment state machine to complete and reach the desired terminal state by checking the region's current state against the table's state (ENABLED vs. DISABLED) to determine if the region is in the terminal state. If not, the region is added to the RIT list; otherwise, it is removed.
Your method naming and comments should communicate this theory of operation.
Related, there may be a minor race condition here. Consider if the table's state is changed (e.g., from ENABLED to DISABLING) at the same time a region for that table reports a state change. I think the tracker can momentarily use a stale table state here. However, this is self-correcting. As the region proceeds through its state transitions each subsequent call to the tracker will re-evaluate its status, and it will eventually be removed from RIT correctly.
There was a problem hiding this comment.
Correct me if I am wrong but I think this race condition might not occur as before changing the state of any table of region (or running any procedure) we first take a lock (setState using HBCK may be an exception). And this lock might save us from this case.
...erver/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionInTransitionTracker.java
Outdated
Show resolved
Hide resolved
...erver/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionInTransitionTracker.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public void clear() { | ||
| regionInTransition.clear(); |
There was a problem hiding this comment.
When the list is cleared this way there are no log lines indicating the regioninfo was removed from the list. Is that a problem?
There was a problem hiding this comment.
renamed the method it to stop, we call it when master/assignment manager is stopping.
Added log line.
Umeshkumar9414
commented
Oct 15, 2025
| static void removeNonDefaultReplicas(MasterProcedureEnv env, Stream<RegionInfo> regions, | ||
| int regionReplication) { | ||
| // Remove from in-memory states | ||
| // TODO should we not confirm here that replica region are closed or not ? |
There was a problem hiding this comment.
@apurtell can you help me here? I was curious here why we are not confirming if replica regions are closed or not?
There was a problem hiding this comment.
I am not sure about this either.
added 7 commits
October 30, 2025 02:55
Umeshkumar9414
force-pushed
the
HBASE-28158_2
branch
from
0535506 to
1ebf4f7
Compare
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.