Skip to content

HBASE-29652 Chaos testing in ZK mode does not work on hosts with ZNode persistence issue #7383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+37 −2
Open

HBASE-29652 Chaos testing in ZK mode does not work on hosts with ZNode persistence issue #7383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions hbase-it/src/main/java/org/apache/hadoop/hbase/chaos/ChaosAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,33 @@ public void process(WatchedEvent watchedEvent) {
}
};

/**
* Watcher for recreating the ephemeral znode of agent if it is deleted
*/
Watcher ephemeralZnodeWatcher = new Watcher() {
@Override
public void process(WatchedEvent watchedEvent) {
if (watchedEvent.getType() == Event.EventType.NodeDeleted) {
String deletedPath = watchedEvent.getPath();
LOG.warn("Ephemeral znode deleted: {}, attempting to recreate", deletedPath);

// Try to recreate the ephemeral znode
try {
createEphemeralZNode(deletedPath, new byte[0]);
} catch (Exception e) {
LOG.warn("Failed to recreate ephemeral znode: {}", deletedPath, e);
}

// Re-establish the watch
try {
zk.exists(deletedPath, this);
} catch (KeeperException | InterruptedException e) {
LOG.warn("Failed to re-establish watch on ephemeral znode: {}", deletedPath, e);
}
}
}
};

// CALLBACKS: Below are the Callbacks used by Chaos Agent

/**
Expand Down Expand Up @@ -384,8 +411,16 @@ private void register() {
createIfZNodeNotExists(ChaosConstants.CHAOS_AGENT_STATUS_PERSISTENT_ZNODE
+ ChaosConstants.ZNODE_PATH_SEPARATOR + agentName);

createEphemeralZNode(ChaosConstants.CHAOS_AGENT_REGISTRATION_EPIMERAL_ZNODE
+ ChaosConstants.ZNODE_PATH_SEPARATOR + agentName, new byte[0]);
String agentEphemeralPath = ChaosConstants.CHAOS_AGENT_REGISTRATION_EPIMERAL_ZNODE
+ ChaosConstants.ZNODE_PATH_SEPARATOR + agentName;

createEphemeralZNode(agentEphemeralPath, new byte[0]);

try {
zk.exists(agentEphemeralPath, ephemeralZnodeWatcher);
} catch (KeeperException | InterruptedException e) {
LOG.error("Failed to establish watch on ephemeral znode: {}", agentEphemeralPath, e);
}
}

/***
Expand Down