feat: export HudiTableConfig and HudiReadConfig as python enums
#433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
reviewed
Sep 2, 2025
| TIMELINE_LAYOUT_VERSION = "hoodie.timeline.layout.version" | ||
| TIMELINE_TIMEZONE = "hoodie.table.timeline.timezone" | ||
|
|
||
| class HudiReadConfig(Enum): |
Member
There was a problem hiding this comment.
the goal is to auto expose the config enums so we don't have to copy the config strings for another language binding. try to research if this is doable with pyo3 to bind python enum to a rust enum without duplicating every config entry.
Contributor
Author
There was a problem hiding this comment.
@xushiyan i added a macros crate to auto-gen enums for python using pyo3. PTAL if this aligns better with the goal. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement auto enum binding generation for Python APIs to eliminate manual duplication and enable extensible multi-language binding support. Currently only applies to
HudiTableConfigandHudiReadConfig.crates/macros/: new shared macro crate supporting multiple language bindings, other language bindings can be easily extended in the future.closes #404
How are the changes test-covered