Add v3 structs #2065
Merged
Add v3 structs #2065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-phi
commented
Jun 3, 2025
| @@ -289,6 +289,129 @@ def __repr__(self) -> str: | |||
| doc="ID representing sort order for this file", | |||
| ), | |||
| ), | |||
| 3: StructType( | |||
There was a problem hiding this comment.
Happy to make this DRYer if desired, just followed the v1 -> v2 example initially
There was a problem hiding this comment.
I think this is fine for now, since they won't change. I think this is less error-prone.
Fokko
approved these changes
Jun 13, 2025
| @@ -289,6 +289,129 @@ def __repr__(self) -> str: | |||
| doc="ID representing sort order for this file", | |||
| ), | |||
| ), | |||
| 3: StructType( | |||
There was a problem hiding this comment.
I think this is fine for now, since they won't change. I think this is less error-prone.
|
Sorry for the long wait @b-phi, but thanks for adding this 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1982
Rationale for this change
Adds v3 structs for data files, manifest entries, and manifest lists. Necessary for related v3 work.
Are these changes tested?
No, these are just schemas.
Are there any user-facing changes?
No