feat: Make duplicate check optional for adding parquet files #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/iceberg/src/transaction.rs
Outdated
| } | ||
|
|
||
| /// Finished building the action and apply it to the transaction. | ||
| pub async fn apply(self) -> Result<Transaction<'a>> { | ||
| pub async fn apply(self, check_duplicate: bool) -> Result<Transaction<'a>> { |
There was a problem hiding this comment.
We should add an option in FileAppendAction rather in apply method, since this approach can't be extended to more options.
struct FileAppendAction {
check_duplicate: bool
}
impl FileAppendAction {
pub fn check_duplicate(v: bool) -> Self {
this.check_duplicate = v;
self
}
}There was a problem hiding this comment.
@liurenjie1024 Thanks, should be good now 👍
liurenjie1024
approved these changes
Mar 12, 2025
|
Thanks @jonathanc-n for this pr! |
ZENOTME
pushed a commit
to risingwavelabs/iceberg-rust
that referenced
this pull request
Mar 12, 2025
…1034) ## Which issue does this PR close? - Closes apache#1031. ## What changes are included in this PR? Added option for checking duplicates when adding parquet files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FastAppendAction. #1031.What changes are included in this PR?
Added option for checking duplicates when adding parquet files.