Partition Writer Support Part 1: add partition splitter #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may conflict with #1014. But I'm not sure whether #1014 can be reviewed and merge recently. I'm ok to merge any one first and I will fix the conflict later. cc @liurenjie1024 @jonathanc-n @Fokko @Xuanwo @sdd |
ZENOTME
force-pushed
the
pw_1_partition_spliter
branch
from
4ac8823 to
7bc64bb
Compare
|
@ZENOTME I should be able to take a look at this tomorrow |
jonathanc-n
reviewed
Mar 19, 2025
| // # TODO | ||
| // Remove this after partition writer supported. | ||
| #[allow(dead_code)] | ||
| pub struct RecordBatchPartitionsplitter { |
There was a problem hiding this comment.
Suggested change
| pub struct RecordBatchPartitionsplitter { | |
| pub struct RecordBatchPartitionSplitter { |
| partition_batches.push(( | ||
| row, | ||
| filter_record_batch(batch, &filter_array) | ||
| .expect("We should guarantee the filter array is valid"), |
There was a problem hiding this comment.
prefer to propogate error instead of expect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR is part 1 to close #342.
What changes are included in this PR?
The partition writer support will be separate into three PR:
This PR is the first part.
Are these changes tested?