refactor: Split transaction module #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @jonathanc-n for this greate pr, just some minor visibility modifications to snapshot module since they are not public api. Others looks great to me!
Xuanwo
approved these changes
Mar 13, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @jonathanc-n for the change.
liurenjie1024
approved these changes
Mar 14, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @jonathanc-n , LGTM!
Li0k
pushed a commit
to risingwavelabs/iceberg-rust
that referenced
this pull request
Mar 24, 2025
- Closes apache#980 . Split transactions module
Li0k
pushed a commit
to risingwavelabs/iceberg-rust
that referenced
this pull request
Mar 25, 2025
- Closes apache#980 . Split transactions module
xxchan
added a commit
to risingwavelabs/iceberg-rust
that referenced
this pull request
Mar 25, 2025
- Closes apache#980 . Split transactions module Signed-off-by: xxchan <xxchan22f@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Split transactions module