feat(puffin): Make Puffin APIs public #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
fqaiser94
force-pushed
the
public_puffin_apis
branch
2 times, most recently
from
6f87530 to
cafa97f
Compare
fqaiser94
commented
Apr 4, 2025
fqaiser94
force-pushed
the
public_puffin_apis
branch
from
7e50dc5 to
0f185be
Compare
There was a problem hiding this comment.
Thanks @fqaiser94 for this pr, generally LGTM! Left some minor suggestions.
Merged
fqaiser94
force-pushed
the
public_puffin_apis
branch
2 times, most recently
from
512539f to
ccbf5d6
Compare
fqaiser94
force-pushed
the
public_puffin_apis
branch
from
ccbf5d6 to
d9f5ffd
Compare
liurenjie1024
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Last part of #744
With this, Puffin support in iceberg-rust is complete.
What changes are included in this PR?
Are these changes tested?
N/A