Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(puffin): Make Puffin APIs public #1165

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

fqaiser94
Copy link
Contributor

@fqaiser94 fqaiser94 commented Apr 3, 2025

Which issue does this PR close?

Part of #744

What changes are included in this PR?

  • Make Puffin APIs public
  • Turn dead-code warning on (disabled earlier to allow for private development)

Are these changes tested?

N/A

@fqaiser94 fqaiser94 mentioned this pull request Apr 1, 2025
8 tasks
@fqaiser94 fqaiser94 force-pushed the public_puffin_apis branch 2 times, most recently from 6f87530 to cafa97f Compare April 3, 2025 11:48
@fqaiser94 fqaiser94 marked this pull request as ready for review April 4, 2025 11:16
kevinjqliu
kevinjqliu previously approved these changes Apr 5, 2025
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fqaiser94 for this pr, generally LGTM! Left some minor suggestions.

@fqaiser94 fqaiser94 mentioned this pull request Apr 7, 2025
@fqaiser94 fqaiser94 force-pushed the public_puffin_apis branch 2 times, most recently from 512539f to ccbf5d6 Compare April 8, 2025 00:39
@fqaiser94 fqaiser94 force-pushed the public_puffin_apis branch from ccbf5d6 to d9f5ffd Compare April 9, 2025 11:50
@fqaiser94 fqaiser94 requested a review from liurenjie1024 April 9, 2025 12:04
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fqaiser94 for this pr, looks great!

@liurenjie1024 liurenjie1024 merged commit b31ebcc into apache:main Apr 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants