fix(parquet_writer): correctly update upper bound #1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
force-pushed
the
fix/update_stat_max
branch
3 times, most recently
from
57ed320 to
0b1b8a4
Compare
CTTY
reviewed
Jul 19, 2025
| @@ -266,7 +266,7 @@ impl MinMaxColAggregator { | |||
| self.upper_bounds | |||
| .entry(field_id) | |||
| .and_modify(|e| { | |||
| if *e > datum { | |||
| if *e < datum { | |||
There was a problem hiding this comment.
Nice catch! can we also add an unit test for this?
There was a problem hiding this comment.
I will look into it, now it's tested as part of test_parquet_writer
There was a problem hiding this comment.
@CTTY sorry for the delay i've added test_min_max_aggregator test
Erigara
force-pushed
the
fix/update_stat_max
branch
2 times, most recently
from
8b6a3c6 to
98c8c82
Compare
Erigara
force-pushed
the
fix/update_stat_max
branch
from
98c8c82 to
7eb2721
Compare
liurenjie1024
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
It fixes issue with not correct upper bound in case of multiple row groups in parquet file.
Closes #1519
What changes are included in this PR?
>to<for updating upper boundAre these changes tested?
I've changed a test so that this code path is activated.