feat: TableIdent derives PartialOrd #1670
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Sep 12, 2025
| @@ -225,7 +225,7 @@ impl Display for NamespaceIdent { | |||
| } | |||
|
|
|||
| /// TableIdent represents the identifier of a table in the catalog. | |||
| #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, Hash)] | |||
| #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, PartialOrd, Hash)] | |||
There was a problem hiding this comment.
Should we also derive Ord? I think TableIdent supports full order.
There was a problem hiding this comment.
NamespaceIdent does 👍
Given there's no pushback to adding ordering in general, I agree that Ord represents it more accurately.
There was a problem hiding this comment.
Should we update the PR?
Suggested change
| #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, PartialOrd, Hash)] | |
| #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, Ord, Hash)] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1669
What changes are included in this PR?
TableIdentnow derivesPartialOrd.Are these changes tested?
No, it's only derived behavior. I'm happy to add a test, but I'm not 100% convinced it would add value.