TOREE-408: Add support for hdfs and s3 to AddJar. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How to know the reason for the failure of the test? The details said 1 Test Failed for |
|
@liukun1016 It's a bit further up, line 3324. |
URI removes the query fragment from the path component and file name is based on the path. This test used to rely on the fact that the query fragment was included in the file name returned by URL, but this is unreliable. The URL could easily end with some other query param instead of the file name, so the logic wasn't reliable.
rdblue
force-pushed
the
TOREE-408-add-jar-support-hadoop-file-systems
branch
from
b1b436f to
4b2134d
Compare
|
Rebased on master and fixed the test failure. The problem was with the test itself. The addJar code was returning the file name based on a query param instead of the URL's path. Since query params can be in any order and can't be relied upon for correct file names, the right thing to do is to get the filename from the path component. I updated the test to do that. |
|
LGTM, merging if there are no more comments. |
rgbkrk
approved these changes
Jul 20, 2017
lresende
pushed a commit
to lresende/incubator-toree
that referenced
this pull request
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.