Spelling #104
Open
Spelling #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Feb 5, 2025
| @@ -10,7 +10,7 @@ jobs: | |||
| pelican-test: | |||
| env: # source and target branches | |||
| SOURCE: testsite | |||
| TARGET: testsite-${{ github.ref_name }} # each branch has own test output | |||
| TARGET: testsite-${{ github.ref_name }} # each branch has its own test output | |||
There was a problem hiding this comment.
This is a grammar error that I tripped on while looking at this workflow failure
| @@ -179,15 +179,15 @@ def main(): | |||
| parser.add_argument('-y', '--yaml', required=True, help="Pelicanconf YAML file") | |||
| args = parser.parse_args() | |||
|
|
|||
| pelconf_yaml = args.yaml | |||
| sourcepath = os.path.dirname(os.path.realpath(pelconf_yaml)) | |||
| pelicanconf_yaml = args.yaml | |||
There was a problem hiding this comment.
there's nothing horribly wrong w/ using short names, but there didn't seem to be a particularly good reason for it either.
| @@ -50,7 +50,7 @@ def main(): | |||
| with open(file, 'r', encoding='utf-8') as infile: | |||
| contents = infile.read() | |||
|
|
|||
| # This will contain the "globals" after executing the peliconconf.py. | |||
| @@ -1,7 +1,7 @@ | |||
| # Plugin Architecture | |||
|
|
|||
| The plugins used operate at various points in a pelican build. | |||
| Pelican uses signals at various points. These are documented [here](https://docs.getpelican.com/en/latest/plugins.html#list-of-signals). | |||
| Pelican uses [signals](https://docs.getpelican.com/en/latest/plugins.html#list-of-signals) at various points. | |||
There was a problem hiding this comment.
This is an accessibility issue:
Do not use (click) here links
For more information, see:
- https://www.w3.org/QA/Tips/noClickHere
- https://webaim.org/techniques/hypertext/link_text
- https://granicus.com/blog/why-click-here-links-are-bad/
- https://heyoka.medium.com/dont-use-click-here-f32f445d1021
(?i)(?:>|\[)(?:(?:click |)here|link|(?:read |)more)(?:</|\]\()
it'd be really nice if Apache as a best practice blocked people from using (click) here links...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR template is missing "Updating the repository"...
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/infrastructure-actions/actions/runs/13163485276#summary-36737848728
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/infrastructure-actions/actions/runs/13163485493#summary-36737849208
I'm not proposing check-spelling for Apache. It doesn't fit w/ various criteria. But, I think fixing the typos here would be nice regardless.