Skip to content

JCR-5153 escapeIllegalJcrChars does not properly escape non XML #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

JCR-5153 escapeIllegalJcrChars does not properly escape non XML #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions jackrabbit-jcr-commons/src/test/java/org/apache/jackrabbit/util/TextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,19 @@ public void testEscapeIllegalJcr10Chars() throws Exception {

public void testEscapeIllegalJcrChars() throws Exception {
// single and double quote are valid since JCR 2.0
assertEquals("local'name", Text.escapeIllegalJcrChars("local'name"));
assertEquals("local\"name", Text.escapeIllegalJcrChars("local\"name"));
assertEscapeIllegalJcrChars("local'name", "local'name");
assertEscapeIllegalJcrChars("local\"name", "local\"name");
assertEscapeIllegalJcrChars("..", "%2E%2E");
assertEscapeIllegalJcrChars("...", "...");
// FIXME: JCR-5153
assertEscapeIllegalJcrChars("\u000F", "\u000F");
}

private void assertEscapeIllegalJcrChars(String name, String expectedEscapedName) {
String escaped = Text.escapeIllegalJcrChars(name);
assertEquals(expectedEscapedName, escaped);
assertTrue("Escaped name is not valid in JCR local names", Text.isValidJcrLocalName(escaped));
assertEquals(name, Text.unescapeIllegalJcrChars(escaped));
}

public void testEscapeXML() {
Expand Down