Skip to content

Conversation

pdenooijer
Copy link

@pdenooijer pdenooijer commented Jun 15, 2021

Based on #47 but without the deprecations and lots of random commits.

This will resolve JCR-3928.

This capability is required because our on premise S3 solutions uses path style.

@pdenooijer
Copy link
Author

@reschke is there any change this gets merged? It would help out our project immensely as there would be no need to support a patched jackrabbit.

@reschke
Copy link
Contributor

reschke commented Jun 23, 2021

Of course.

I guess a unit test for this is hard to do?

@pdenooijer
Copy link
Author

pdenooijer commented Jun 24, 2021

Thanks for the quick reply!

Back on topic: it won't be easy to unit test in the current setup, as the addition basically just proxies a setting to the AmazonS3Client class. As this is a dependency that is hard coded in the static Util class, it's not easy to mock/replace/etc.

@pdenooijer
Copy link
Author

pdenooijer commented Jun 24, 2021

See you committed it, thanks! See 426b4c2

@pdenooijer pdenooijer closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants