-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: improve KS docs about recommended configs #18516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM, just have one minor update
<li><a class="reference internal" href="#id2" id="id23">replication.factor</a></li> | ||
<li><a class="reference internal" href="#acks-short" id="id22">acks</a></li> | ||
<li><a class="reference internal" href="#replication-factor-short" id="id23">replication.factor</a></li> | ||
<li><a class="reference internal" href="#min-isr-short" id="id44">replication.factor</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this li
should be min.insync.replicas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. C&P error.
<li><a class="reference internal" href="#acks-short" id="id22">acks</a></li> | ||
<li><a class="reference internal" href="#replication-factor-short" id="id23">replication.factor</a></li> | ||
<li><a class="reference internal" href="#min-isr-short" id="id44">replication.factor</a></li> | ||
<li><a class="reference internal" href="#num-standby-replicas-short" id="id45">replication.factor</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here the li
text should be num.standby.replicas
Merged to |
Reviewers: Bill Bejeck <[email protected]>
Reviewers: Bill Bejeck <[email protected]>
Reviewers: Bill Bejeck <[email protected]>
Reviewers: Bill Bejeck <[email protected]>
No description provided.