Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: improve KS docs about recommended configs #18516

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Jan 14, 2025

No description provided.

@github-actions github-actions bot added the small Small PRs label Jan 14, 2025
Copy link
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just have one minor update

<li><a class="reference internal" href="#id2" id="id23">replication.factor</a></li>
<li><a class="reference internal" href="#acks-short" id="id22">acks</a></li>
<li><a class="reference internal" href="#replication-factor-short" id="id23">replication.factor</a></li>
<li><a class="reference internal" href="#min-isr-short" id="id44">replication.factor</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this li should be min.insync.replicas

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. C&P error.

<li><a class="reference internal" href="#acks-short" id="id22">acks</a></li>
<li><a class="reference internal" href="#replication-factor-short" id="id23">replication.factor</a></li>
<li><a class="reference internal" href="#min-isr-short" id="id44">replication.factor</a></li>
<li><a class="reference internal" href="#num-standby-replicas-short" id="id45">replication.factor</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here the li text should be num.standby.replicas

@mjsax mjsax merged commit 65daa1d into apache:trunk Jan 15, 2025
4 checks passed
@mjsax mjsax deleted the minor-ks-configs-docs branch January 15, 2025 18:02
@mjsax
Copy link
Member Author

mjsax commented Jan 15, 2025

Merged to trunk and cherry-picked to 4.0 branch.

mjsax added a commit that referenced this pull request Jan 15, 2025
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants