MINOR: improve KS docs about recommended configs #18516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbejeck
approved these changes
Jan 15, 2025
| <li><a class="reference internal" href="#id2" id="id23">replication.factor</a></li> | ||
| <li><a class="reference internal" href="#acks-short" id="id22">acks</a></li> | ||
| <li><a class="reference internal" href="#replication-factor-short" id="id23">replication.factor</a></li> | ||
| <li><a class="reference internal" href="#min-isr-short" id="id44">replication.factor</a></li> |
There was a problem hiding this comment.
this li should be min.insync.replicas
| <li><a class="reference internal" href="#acks-short" id="id22">acks</a></li> | ||
| <li><a class="reference internal" href="#replication-factor-short" id="id23">replication.factor</a></li> | ||
| <li><a class="reference internal" href="#min-isr-short" id="id44">replication.factor</a></li> | ||
| <li><a class="reference internal" href="#num-standby-replicas-short" id="id45">replication.factor</a></li> |
There was a problem hiding this comment.
same here the li text should be num.standby.replicas
|
Merged to |
mjsax
added a commit
that referenced
this pull request
Jan 15, 2025
Reviewers: Bill Bejeck <[email protected]>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Bill Bejeck <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Bill Bejeck <[email protected]>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Reviewers: Bill Bejeck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.