Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: avoid WARN logs in KafkaStreams test #18517

Merged
merged 1 commit into from
Jan 15, 2025
Merged

MINOR: avoid WARN logs in KafkaStreams test #18517

merged 1 commit into from
Jan 15, 2025

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Jan 14, 2025

Avoiding 'WARN Method #getTimestampedKeyValueStore() should be used to access a TimestampedKeyValueStore.' running KTableKTableForeignKeyJoinIntegrationTest.

@mjsax
MINOR: avoid WARN logs in KafkaStreams test
f101301 
Avoiding 'WARN Method #getTimestampedKeyValueStore() should be
used to access a TimestampedKeyValueStore.' running
KTableKTableForeignKeyJoinIntegrationTest.
@mjsax mjsax added streams tests Test fixes (including flaky tests) labels Jan 14, 2025
@github-actions github-actions bot added the small Small PRs label Jan 14, 2025
mjsax
mjsax commented Jan 14, 2025
View reviewed changes
...est/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java
final HashMap<String, String> result = new HashMap<>();
store.all().forEachRemaining(kv -> result.put(kv.key, kv.value));
try (final KeyValueIterator<String, ValueAndTimestamp<String>> it = store.all()) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional side cleanup.

bbejeck
bbejeck approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjsax
Copy link
Member Author

mjsax commented Jan 15, 2025

Java 17:

Found 2 flaky test failures:
FLAKY ⚠️  ShareConsumerTest > testAcknowledgementCommitCallbackInvalidRecordStateException(String).persister=org.apache.kafka.server.share.persister.NoOpShareStatePersister
FLAKY ⚠️  AbstractCoordinatorTest > testWakeupAfterSyncGroupReceivedExternalCompletion()

Java 23:

Found 1 flaky test failures:
FLAKY ⚠️  PlaintextConsumerTest > testCloseLeavesGroupOnInterrupt(String, String).quorum=kraft.groupProtocol=classic

@mjsax
Copy link
Member Author

mjsax commented Jan 15, 2025

Java 17

Found 2 flaky test failures:
FLAKY ⚠️  OffsetFetchRequestTest > testSingleGroupAllOffsetFetchWithOldConsumerGroupProtocolAndOldGroupCoordinator [1] Type=Raft-Isolated, MetadataVersion=4.0-IV3,BrokerSecurityProtocol=PLAINTEXT,BrokerListenerName=ListenerName(EXTERNAL),ControllerSecurityProtocol=PLAINTEXT,ControllerListenerName=ListenerName(CONTROLLER)
FLAKY ⚠️  RemoteLogManagerTest > testRLMOpsWhenMetadataIsNotReady()

Java 23

Found 3 flaky test failures:
FLAKY ⚠️  PlaintextProducerSendTest > testCloseWithZeroTimeoutFromCallerThread(String, String).quorum=kraft.groupProtocol=consumer
FLAKY ⚠️  MetricsDuringTopicCreationDeletionTest > "testMetricsDuringTopicCreateDelete(String).quorum=kraft"
FLAKY ⚠️  AbstractCoordinatorTest > testWakeupAfterSyncGroupReceivedExternalCompletion()

@mjsax mjsax merged commit 0bc770d into apache:trunk Jan 15, 2025
9 of 11 checks passed
@mjsax mjsax deleted the minor-test-cleanup branch January 15, 2025 22:08
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
@mjsax @pranavt84
MINOR: avoid WARN logs in KafkaStreams test (apache#18517)
5aa120f 
Avoiding 'WARN Method #getTimestampedKeyValueStore() should be
used to access a TimestampedKeyValueStore.' running
KTableKTableForeignKeyJoinIntegrationTest.

Reviewers: Bill Bejeck <[email protected]>
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
@mjsax
MINOR: avoid WARN logs in KafkaStreams test (apache#18517)
58ade8a 
Avoiding 'WARN Method #getTimestampedKeyValueStore() should be
used to access a TimestampedKeyValueStore.' running
KTableKTableForeignKeyJoinIntegrationTest.

Reviewers: Bill Bejeck <[email protected]>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
@mjsax @manoj-mathivanan
MINOR: avoid WARN logs in KafkaStreams test (apache#18517)
988fa91 
Avoiding 'WARN Method #getTimestampedKeyValueStore() should be
used to access a TimestampedKeyValueStore.' running
KTableKTableForeignKeyJoinIntegrationTest.

Reviewers: Bill Bejeck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbejeck bbejeck bbejeck approved these changes

Assignees
No one assigned
Labels
small Small PRs streams tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjsax @bbejeck