-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-18518: Add processor to handle rebalance events #18527
Merged
+1,366
−1
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9709592
KAFKA-18518: Add processor to handle rebalance events
cadonna dc845c0
Add license headers
cadonna 21c4bee
Apply spotless
cadonna 29dd4e0
Add javadocs
cadonna e7ac06e
Improve TaskId
cadonna c653ddd
Improve Assignment
cadonna 88d016c
Add null checks to TaskId
cadonna cc8e0b5
Improve subtopology
cadonna de35989
Improve topic info
cadonna 31f170d
Improve streams rebalance data
cadonna eadecd3
Put types of background event on separate lines
cadonna a319b91
Harmonize implementations of callbacks invocations
cadonna 2015d24
fix checkstyle issues
cadonna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Harmonize implementations of callbacks invocations
commit a319b91c4dea83cf07575203aef6b639161ea0f9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package org.apache.kafka.clients.consumer.internals; | ||
Check notice on line 1 in clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsRebalanceDataTest.java
|
||
import org.junit.jupiter.api.Test; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invokeOnTasksRevokedCallback
has a different implementation thaninvokeOnTasksAssignedCallback
andinvokeOnAllTasksLostCallback
. It's probably easier to read if all three use either the.map
stile or theisPresent
style. I don't mind which one,isPresent
is probably a little easier to follow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I just applied IDEA's recommendation to transform it to functional style. However, I agree with you regarding readability.