Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18520: Remove ZooKeeper logic from JaasUtils #18530

Merged
merged 1 commit into from
Jan 15, 2025
Merged

KAFKA-18520: Remove ZooKeeper logic from JaasUtils #18530

merged 1 commit into from
Jan 15, 2025

Conversation

mimaison
Copy link
Member

These methods are not called anymore so they can be removed.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added clients small Small PRs labels Jan 14, 2025
chia7712
chia7712 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It seems this package is a part of public APIs, but it should be fine to remove those zk logic in 4.0

@mimaison
Copy link
Member Author

Yeah I consider these covered by the ZooKeeper removal KIPs.

@mimaison mimaison merged commit 66b1f00 into apache:trunk Jan 15, 2025
7 of 9 checks passed
@mimaison mimaison deleted the kafka-18520 branch January 15, 2025 12:17
mimaison added a commit that referenced this pull request Jan 15, 2025
@mimaison
KAFKA-18520: Remove ZooKeeper logic from JaasUtils (#18530)
d5ff490 
Reviewers: Chia-Ping Tsai <[email protected]>
@mimaison
Copy link
Member Author

Applied to 4.0: d5ff490

pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
@mimaison @pranavt84
KAFKA-18520: Remove ZooKeeper logic from JaasUtils (apache#18530)
1030731 
Reviewers: Chia-Ping Tsai <[email protected]>
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
@mimaison @mjsax
KAFKA-18520: Remove ZooKeeper logic from JaasUtils (apache#18530)
9b3caf2 
Reviewers: Chia-Ping Tsai <[email protected]>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
@mimaison @manoj-mathivanan
KAFKA-18520: Remove ZooKeeper logic from JaasUtils (apache#18530)
ffaee73 
Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
clients small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mimaison @chia7712