KAFKA-14485: Move LogCleaner exceptions to storage module #18534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
showuon
approved these changes
Jan 16, 2025
| @@ -1241,9 +1240,9 @@ class LogCleanerTest extends Logging { | |||
| val log = makeLog(config = LogConfig.fromProps(logConfig.originals, logProps)) | |||
|
|
|||
| // create 6 segments with only one message in each segment | |||
| def createRecorcs = TestUtils.singletonRecords(value = Array.fill[Byte](25)(0), key = 1.toString.getBytes) | |||
| def createRecords = TestUtils.singletonRecords(value = Array.fill[Byte](25)(0), key = 1.toString.getBytes) | |||
| .take(numCleanableSegments).forall { case (before, after) => after < before }, | ||
| "The cleanable segments should have fewer number of values after cleaning") | ||
| assertTrue(disctinctValuesBySegmentBeforeClean.zip(distinctValuesBySegmentAfterClean) | ||
| assertTrue(distinctValuesBySegmentBeforeClean.zip(distinctValuesBySegmentAfterClean) |
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Luke Chen <[email protected]>, Ken Huang <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Luke Chen <[email protected]>, Ken Huang <[email protected]>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Reviewers: Luke Chen <[email protected]>, Ken Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)