-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-18514: Remove server dependency from share coordinator #18536
KAFKA-18514: Remove server dependency from share coordinator #18536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Unrelated tests failure, re-triggering build though. |
@chia7712 @ijuma Unrelated test failure, seems the failed test is fixed in: https://github.com/apache/kafka/pull/18549/files. Rest are flaky. |
I'm going to merge it :) |
The PR removes dependency of server module on share-coordinator, rather it should be other way. Moved the ShareCoordinatorConfig class from server to share-coordinator. Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
The PR removes dependency of server module on share-coordinator, rather it should be other way. Moved the ShareCoordinatorConfig class from server to share-coordinator. Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
The PR removes dependency of server module on share-coordinator, rather it should be other way. Moved the ShareCoordinatorConfig class from server to share-coordinator. Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
The PR removes dependency of server module on share-coordinator, rather it should be other way. Moved the ShareCoordinatorConfig class from server to share-coordinator. Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
The PR removes dependency of
server
module onshare-coordinator
, rather it should be other way. Moved theShareCoordinatorConfig
class fromserver
toshare-coordinator
.Committer Checklist (excluded from commit message)