Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18514: Remove server dependency from share coordinator #18536

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

apoorvmittal10
Copy link
Collaborator

The PR removes dependency of server module on share-coordinator, rather it should be other way. Moved the ShareCoordinatorConfig class from server to share-coordinator.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added the triage PRs from the community label Jan 14, 2025
@apoorvmittal10 apoorvmittal10 requested a review from ijuma January 14, 2025 18:15
@github-actions github-actions bot added core Kafka Broker KIP-932 Queues for Kafka build Gradle build or GitHub Actions small Small PRs labels Jan 14, 2025
@apoorvmittal10 apoorvmittal10 added KIP-932 Queues for Kafka and removed KIP-932 Queues for Kafka small Small PRs labels Jan 14, 2025
Copy link
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@apoorvmittal10 apoorvmittal10 changed the title KAFKA-18514: Remove server dependency on share coordinator KAFKA-18514: Remove server dependency from share coordinator Jan 14, 2025
@apoorvmittal10
Copy link
Collaborator Author

Unrelated tests failure, re-triggering build though.

@github-actions github-actions bot added small Small PRs and removed triage PRs from the community labels Jan 14, 2025
@apoorvmittal10
Copy link
Collaborator Author

@chia7712 @ijuma Unrelated test failure, seems the failed test is fixed in: https://github.com/apache/kafka/pull/18549/files. Rest are flaky.

@apoorvmittal10
Copy link
Collaborator Author

@chia7712 @ijuma Can it be merged or I need to trigger the build again? Though flaky tests exists in multiple runs.

@chia7712
Copy link
Member

Can it be merged or I need to trigger the build again? Though flaky tests exists in multiple runs.

I'm going to merge it :)

@chia7712 chia7712 merged commit e12db66 into apache:trunk Jan 15, 2025
7 of 9 checks passed
ijuma pushed a commit that referenced this pull request Jan 16, 2025
The PR removes dependency of server module on share-coordinator, rather it should be other way. Moved the ShareCoordinatorConfig class from server to share-coordinator.

Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
The PR removes dependency of server module on share-coordinator, rather it should be other way. Moved the ShareCoordinatorConfig class from server to share-coordinator.

Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
The PR removes dependency of server module on share-coordinator, rather it should be other way. Moved the ShareCoordinatorConfig class from server to share-coordinator.

Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
The PR removes dependency of server module on share-coordinator, rather it should be other way. Moved the ShareCoordinatorConfig class from server to share-coordinator.

Reviewers: Ismael Juma <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle build or GitHub Actions core Kafka Broker KIP-932 Queues for Kafka small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants