MINOR: close mockClient within AbstractCoordinatorTest #18538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
TaiJuWu
force-pushed
the
close_coordinator
branch
from
c848fc9 to
b079bc8
Compare
TaiJuWu
changed the title
|
Can we merge master? It has a fix that will fix the build timeouts. |
Sure. |
|
Revert the flaky tag since it still happened in previous CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try resolve flaky test
AbstractCoordinatorTest, I found we don't closemockClientbut these issues can't reproduce on my local so I can't verify it is useful or not.Committer Checklist (excluded from commit message)