Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KAFKA-18454] Publish build scans to develocity.apache.org #18539

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

clayburn
Copy link
Contributor

@clayburn clayburn commented Jan 14, 2025

This PR migrates the Kafka project to publish Build Scans to the the new Develocity instance at develocity.apache.org.

https://issues.apache.org/jira/browse/KAFKA-18454

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions small Small PRs labels Jan 14, 2025
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clayburn thanks for this contribution!

@github-actions github-actions bot removed the triage PRs from the community label Jan 15, 2025
@mimaison
Copy link
Member

@chia7712 Can we merge this?

@chia7712
Copy link
Member

merge trunk to run QA again

@chia7712
Copy link
Member

merge trunk and upgrade the plugin to 3.19

@clayburn do you have any idea that the publish task always say there is no previous data? I don't dig in it, but other PRs don't encounter such error. Hence, the error should be related to this PR

@clayburn
Copy link
Contributor Author

I think it is because you triggered those via workflow dispatch, when really the CI Complete workflow needs to have a corresponding run of the CI workflow. Without that corresponding run, there was no previous scan to publish. If the only purpose of that workflow is to publish build scans, then I'm not sure it makes sense to have a workflow dispatch trigger.

I believe @mumrah authored this workflow for publishing scans from forked builds, so he may know more.

Copy link
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clayburn is correct about the workflow dispatch. To work around repository secret restrictions, we archive each PR's build scan as a Github build artifact and upload it in a separate job. This works using Gradle's "buildScanPublishPrevious" task which reads the server from settings.gradle.

I think this patch should work fine on trunk.

Thanks for the fix @clayburn!

@mumrah mumrah merged commit e9e03fa into apache:trunk Jan 21, 2025
6 of 9 checks passed
@chia7712
Copy link
Member

chia7712 commented Jan 25, 2025

@clayburn @mumrah thanks for your response and explanation!

mumrah pushed a commit that referenced this pull request Jan 27, 2025
This patch includes some maintenance updates for Develocity.

* Publish build scans to develocity.apache.org
* Update Develocity Gradle plugin to to 3.19
* Use `DEVELOCITY_ACCESS_KEY` to authenticate to `develocity.apache.org`

Reviewers: Chia-Ping Tsai <[email protected]>, David Arthur <[email protected]>
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
This patch includes some maintenance updates for Develocity.

* Publish build scans to develocity.apache.org
* Update Develocity Gradle plugin to to 3.19
* Use `DEVELOCITY_ACCESS_KEY` to authenticate to `develocity.apache.org`

Reviewers: Chia-Ping Tsai <[email protected]>, David Arthur <[email protected]>
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
This patch includes some maintenance updates for Develocity.

* Publish build scans to develocity.apache.org
* Update Develocity Gradle plugin to to 3.19
* Use `DEVELOCITY_ACCESS_KEY` to authenticate to `develocity.apache.org`

Reviewers: Chia-Ping Tsai <[email protected]>, David Arthur <[email protected]>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
This patch includes some maintenance updates for Develocity.

* Publish build scans to develocity.apache.org
* Update Develocity Gradle plugin to to 3.19
* Use `DEVELOCITY_ACCESS_KEY` to authenticate to `develocity.apache.org`

Reviewers: Chia-Ping Tsai <[email protected]>, David Arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle build or GitHub Actions ci-approved small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants