-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KAFKA-18454] Publish build scans to develocity.apache.org #18539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clayburn thanks for this contribution!
@chia7712 Can we merge this? |
merge trunk to run QA again |
merge trunk and upgrade the plugin to 3.19 @clayburn do you have any idea that the publish task always say there is no previous data? I don't dig in it, but other PRs don't encounter such error. Hence, the error should be related to this PR |
I think it is because you triggered those via workflow dispatch, when really the CI Complete workflow needs to have a corresponding run of the CI workflow. Without that corresponding run, there was no previous scan to publish. If the only purpose of that workflow is to publish build scans, then I'm not sure it makes sense to have a workflow dispatch trigger. I believe @mumrah authored this workflow for publishing scans from forked builds, so he may know more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clayburn is correct about the workflow dispatch. To work around repository secret restrictions, we archive each PR's build scan as a Github build artifact and upload it in a separate job. This works using Gradle's "buildScanPublishPrevious" task which reads the server from settings.gradle.
I think this patch should work fine on trunk.
Thanks for the fix @clayburn!
This patch includes some maintenance updates for Develocity. * Publish build scans to develocity.apache.org * Update Develocity Gradle plugin to to 3.19 * Use `DEVELOCITY_ACCESS_KEY` to authenticate to `develocity.apache.org` Reviewers: Chia-Ping Tsai <[email protected]>, David Arthur <[email protected]>
This patch includes some maintenance updates for Develocity. * Publish build scans to develocity.apache.org * Update Develocity Gradle plugin to to 3.19 * Use `DEVELOCITY_ACCESS_KEY` to authenticate to `develocity.apache.org` Reviewers: Chia-Ping Tsai <[email protected]>, David Arthur <[email protected]>
This patch includes some maintenance updates for Develocity. * Publish build scans to develocity.apache.org * Update Develocity Gradle plugin to to 3.19 * Use `DEVELOCITY_ACCESS_KEY` to authenticate to `develocity.apache.org` Reviewers: Chia-Ping Tsai <[email protected]>, David Arthur <[email protected]>
This patch includes some maintenance updates for Develocity. * Publish build scans to develocity.apache.org * Update Develocity Gradle plugin to to 3.19 * Use `DEVELOCITY_ACCESS_KEY` to authenticate to `develocity.apache.org` Reviewers: Chia-Ping Tsai <[email protected]>, David Arthur <[email protected]>
This PR migrates the Kafka project to publish Build Scans to the the new Develocity instance at develocity.apache.org.
https://issues.apache.org/jira/browse/KAFKA-18454
Committer Checklist (excluded from commit message)